View Issue Details

IDProjectCategoryView StatusLast Update
0008257Talerwallet-corepublic2024-04-15 19:32
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.10Fixed in Version0.10 
Summary0008257: wallet-core checkPeerPushDebit and getWithdrawalDetailsForAmount requests are extremely slow for larger amounts [estimate: 8h]
DescriptionLikely some DB transaction is missing an index. Furthermore we should do caching.

And unless the response is *always* very fast, we should consider a way to cancel ongoing requests when the UI doesn't even need the old data anymore.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2024-03-05 22:39

manager   ~0021706

Likely cause: failure to only look at *active* denomination groups for withdraw (and instead iterating over tons of denomination keys in the DB).

Florian Dold

2024-03-31 16:14

manager   ~0022065

Last edited: 2024-03-31 16:30

Things still missing for decent performance:
* in-mem caching of denom selection
* in-mem caching of refresh cost
* in-mem caching of the conversion API response
* denomination families in the wallet-core DB

Florian Dold

2024-04-08 20:55

manager   ~0022161

commit ca60e97755d91d73b4f5fc3992ddb2db524cd5f2 (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Mon Apr 8 22:52:53 2024 +0200

    wallet-core: fix cancellation

commit 18b77088bfc8699dfff64b70bb65b915f08d0fb6
Author: Florian Dold <florian@dold.me>
Date: Mon Apr 8 22:34:42 2024 +0200

    -parsing

commit 859d5c56c7a5b26e741254d6d1e9c5731a787ae1
Author: Florian Dold <florian@dold.me>
Date: Mon Apr 8 22:29:51 2024 +0200

    wallet-core: support cancellation for getWithdrawalDetailsForAmount

Issue History

Date ModifiedUsernameFieldChange
2024-01-24 14:16Florian DoldNew Issue
2024-01-24 14:16Florian DoldStatusnew => assigned
2024-01-24 14:16Florian DoldAssigned To => Florian Dold
2024-01-24 14:19Florian DoldSummarywallet-core checkPeerPushDebit request is extremely slow for larger amounts => wallet-core checkPeerPushDebit and getWithdrawalDetailsForAmount requests are extremely slow for larger amounts
2024-03-05 22:39Christian GrothoffNote Added: 0021706
2024-03-27 20:18Florian DoldSummarywallet-core checkPeerPushDebit and getWithdrawalDetailsForAmount requests are extremely slow for larger amounts => wallet-core checkPeerPushDebit and getWithdrawalDetailsForAmount requests are extremely slow for larger amounts [estimate: 8h]
2024-03-31 16:14Florian DoldNote Added: 0022065
2024-03-31 16:30Florian DoldNote Edited: 0022065
2024-04-08 20:55Florian DoldStatusassigned => informing
2024-04-08 20:55Florian DoldResolutionopen => fixed
2024-04-08 20:55Florian DoldNote Added: 0022161
2024-04-09 11:11Christian GrothoffFixed in Version => 0.10
2024-04-15 19:32Christian GrothoffStatusinforming => closed