View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008251 | Taler | wallet-core | public | 2024-01-24 13:21 | 2024-04-15 19:32 |
| Reporter | Christian Grothoff | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.10 | Fixed in Version | 0.10 | ||
| Summary | 0008251: P2P payments fail strangely when exchange global fees are not configured | ||||
| Description | I had an exchange where the 'global fees' were not set up. The wallet should not even TRY to do P2P payments, as it has no fees (via /keys). Instead, it tries, and the exchange logs: `/purses/0RGFWN65HJVR4J2NG6PP1V8VSH4WYXXR4J9W4KZ5GTSAZ3B8STYG/create' completed with HTTP status 500 .. Create purse: global fees not configured! Which is kind-of OK, we can argue about this being 500 or 400. Anyway, the wallet NEVERTHELESS proceeds and shows a QR code. Scanning the QR code then results in a 404 "contract not found". The wallet should handle the case better where the exchange returns errors (do not continue anyway!) and should probably not allow P2P payments if they are not configured! | ||||
| Tags | No tags attached. | ||||
| It's rather unclear that the main indicator for "p2p payments are not supported/configured" is the "purse_fee" field. IMO to do this properly, wallet-core needs to communicate the features that the exchange supports to the UI (via flags in the ExchangeEntry when exchanges are listed/queried). @Christian can you please: * confirm that purse_fee in global_fees is indeed the best/primary/only indicator that p2p payments are disabled * check whether there are other obvious exchange features that can be enabled/disabled and that wallet-core needs to flag to the UIs for good UX? | |
| Not specifically the 'purse_fee' field, but the existence of any entry in the global_fees array for the current time (between start_date and end_date) should be used. The other features to be enabled/disabled would related to extensions, which are currently not implemented. But in the future, extensions would fall into this category. You probably also should signal the 'asset_type' from /keys, as that may determine how the UI does render things. | |
| commit 30e5b7f6bf6fe7810f3fe0778e203b0e54d34b40 (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Wed Mar 27 19:03:26 2024 +0100 wallet-core: report more info about (missing) fees | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-24 13:21 | Christian Grothoff | New Issue | |
| 2024-01-24 13:21 | Christian Grothoff | Status | new => assigned |
| 2024-01-24 13:21 | Christian Grothoff | Assigned To | => Florian Dold |
| 2024-01-29 12:10 | Florian Dold | Note Added: 0021073 | |
| 2024-01-29 12:10 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2024-01-29 12:10 | Florian Dold | Status | assigned => feedback |
| 2024-01-29 13:59 | Christian Grothoff | Note Added: 0021075 | |
| 2024-01-29 13:59 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2024-01-29 14:00 | Christian Grothoff | Status | feedback => assigned |
| 2024-03-04 12:13 | Florian Dold | Summary | P2P payments fail strangely... => P2P payments fail strangely when exchange global fees are not configured |
| 2024-03-27 18:03 | Florian Dold | Status | assigned => informing |
| 2024-03-27 18:03 | Florian Dold | Resolution | open => fixed |
| 2024-03-27 18:03 | Florian Dold | Note Added: 0022011 | |
| 2024-04-09 11:11 | Christian Grothoff | Fixed in Version | => 0.10 |
| 2024-04-15 19:32 | Christian Grothoff | Status | informing => closed |