View Issue Details

IDProjectCategoryView StatusLast Update
0008202Talerexchangepublic2024-03-07 19:47
Reporterfefe Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008202: TALER_EXCHANGE_management_revoke_signing_key: memory leak
DescriptionThis is in exchange/src/lib/exchange_api_management_revoke_signing_key.c:

157 if (NULL == rh->url)
158 {
159 GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
160 "Could not construct request URL.\n");
161 GNUNET_free (rh);
162 return NULL;
163 }
164 body = GNUNET_JSON_PACK (
165 GNUNET_JSON_pack_data_auto ("master_sig",
166 master_sig));
167 eh = TALER_EXCHANGE_curl_easy_get_ (rh->url);
168 if ( (NULL == eh) ||
169 (GNUNET_OK !=
170 TALER_curl_easy_post (&rh->post_ctx,
171 eh,
172 body)) )
173 {
174 GNUNET_break (0);
175 if (NULL != eh)
176 curl_easy_cleanup (eh);
177 json_decref (body);
178 GNUNET_free (rh->url);
179 return NULL;
180 }

It looks like a GNUNET_free(rh) is missing in the lower cleanup clause.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0008112 implementingoec Merchant security review 

Activities

Christian Grothoff

2024-01-22 16:03

manager   ~0020959

Fixed in 75a0ab25..f56af0cd

Issue History

Date ModifiedUsernameFieldChange
2024-01-22 14:49fefeNew Issue
2024-01-22 14:49fefeStatusnew => assigned
2024-01-22 14:49fefeAssigned To => Christian Grothoff
2024-01-22 16:01Christian GrothoffRelationship addedchild of 0008112
2024-01-22 16:03Christian GrothoffStatusassigned => informing
2024-01-22 16:03Christian GrothoffResolutionopen => fixed
2024-01-22 16:03Christian GrothoffFixed in Version => 0.9.4
2024-01-22 16:03Christian GrothoffNote Added: 0020959
2024-01-22 16:04Christian GrothoffProduct Version => git (master)
2024-01-22 16:04Christian GrothoffTarget Version => 0.9.4
2024-03-07 19:47Christian GrothoffStatusinforming => closed