View Issue Details

IDProjectCategoryView StatusLast Update
0008200Talerexchangepublic2024-03-07 19:47
Reporterfefe Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Fixed in Version0.9.4 
Summary0008200: TALER_EXCHANGE_management_revoke_denomination_key: memory leak
DescriptionThis is in exchange/src/lib/exchange_api_management_revoke_denomination_key.c:

170 if (NULL == body)
171 {
172 GNUNET_break (0);
173 GNUNET_free (rh->url);
174 GNUNET_free (rh);
175 return NULL;
176 }
177 eh = TALER_EXCHANGE_curl_easy_get_ (rh->url);
178 if ( (NULL == eh) ||
179 (GNUNET_OK !=
180 TALER_curl_easy_post (&rh->post_ctx,
181 eh,
182 body)) )
183 {
184 GNUNET_break (0);
185 if (NULL != eh)
186 curl_easy_cleanup (eh);
187 json_decref (body);
188 GNUNET_free (rh->url);
189 return NULL;
190 }

This looks like a GNUNET_free(rh) is missing in the second cleanup clause.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0008112 implementingoec Merchant security review 

Activities

Christian Grothoff

2024-01-22 15:48

manager   ~0020957

Fixed in d752938c..75a0ab25

Issue History

Date ModifiedUsernameFieldChange
2024-01-22 14:30fefeNew Issue
2024-01-22 14:30fefeStatusnew => assigned
2024-01-22 14:30fefeAssigned To => Christian Grothoff
2024-01-22 15:48Christian GrothoffStatusassigned => informing
2024-01-22 15:48Christian GrothoffResolutionopen => fixed
2024-01-22 15:48Christian GrothoffNote Added: 0020957
2024-01-22 15:49Christian GrothoffRelationship addedchild of 0008112
2024-02-10 22:31Christian GrothoffFixed in Version => 0.9.4
2024-03-07 19:47Christian GrothoffStatusinforming => closed