View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008104 | Taler | exchange | public | 2024-01-18 13:33 | 2024-03-07 19:47 |
| Reporter | fefe | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0008104: parse_json_denomkey_partially: memory leak? | ||||
| Description | This is in exchange/src/lib/exchange_api_handle.c: 520 /* invalidate denom_key, just to be sure */ 521 memset (denom_key, 522 0, 523 sizeof (*denom_key)); 524 GNUNET_JSON_parse_free (spec); 525 return GNUNET_SYSERR; 526 } denom_key contains an embedded pointer: 460 struct TALER_EXCHANGE_DenomPublicKey *denom_key, 71 struct TALER_EXCHANGE_DenomPublicKey 72 { 73 /** 74 * The public key 75 */ 76 struct TALER_DenominationPublicKey key; 1229 struct TALER_DenominationPublicKey 1230 { 1231 1232 /** 1233 * Age restriction mask used for the key. 1234 */ 1235 struct TALER_AgeMask age_mask; 1236 1237 /** 1238 * Type of the public key. 1239 */ 1240 struct GNUNET_CRYPTO_BlindSignPublicKey *bsign_pub_key; 1241 1242 }; If I read the code right, this public key came out of the json parser. I think if you just memset the struct here, you leak the memory of the key. | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-18 13:33 | fefe | New Issue | |
| 2024-01-18 13:33 | fefe | Status | new => assigned |
| 2024-01-18 13:33 | fefe | Assigned To | => Christian Grothoff |
| 2024-01-18 21:33 | Christian Grothoff | Status | assigned => informing |
| 2024-01-18 21:33 | Christian Grothoff | Resolution | open => fixed |
| 2024-01-18 21:33 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-01-18 21:33 | Christian Grothoff | Note Added: 0020912 | |
| 2024-01-18 21:33 | Christian Grothoff | Target Version | => 0.9.4 |
| 2024-01-18 22:30 | Christian Grothoff | Relationship added | child of 0008112 |
| 2024-03-07 19:47 | Christian Grothoff | Status | informing => closed |