View Issue Details

IDProjectCategoryView StatusLast Update
0008089Talerexchangepublic2024-03-07 19:47
Reporterfefe Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008089: reserve_batch_withdraw_ok: index should be size_t
DescriptionThis is in exchange/src/lib/exchange_api_batch_withdraw2.c:

110 unsigned int index;

123 json_array_foreach (ja, index, j)

which expands to:

243 #define json_array_foreach(array, index, value) \
244 for (index = 0; \
245 index < json_array_size(array) && (value = json_array_get(array, index)); \
246 index++)

json_array_size returns a size_t, so index should be a size_t, too.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0008112 implementingoec Merchant security review 

Activities

fefe

2024-01-15 15:29

reporter   ~0020876

Further down in the function:

137 for (unsigned int i = 0; i<index; i++)
138 TALER_blinded_denom_sig_free (&blind_sigs[i]);

i should be a size_t, too.

Christian Grothoff

2024-01-15 15:44

manager   ~0020877

Fixed in 6c1400044..4cf9e0000

Issue History

Date ModifiedUsernameFieldChange
2024-01-15 15:27fefeNew Issue
2024-01-15 15:27fefeStatusnew => assigned
2024-01-15 15:27fefeAssigned To => Christian Grothoff
2024-01-15 15:29fefeNote Added: 0020876
2024-01-15 15:44Christian GrothoffStatusassigned => informing
2024-01-15 15:44Christian GrothoffResolutionopen => fixed
2024-01-15 15:44Christian GrothoffFixed in Version => 0.9.4
2024-01-15 15:44Christian GrothoffNote Added: 0020877
2024-01-15 15:44Christian GrothoffProduct Version => git (master)
2024-01-15 15:44Christian GrothoffTarget Version => 0.9.4
2024-01-18 22:32Christian GrothoffRelationship addedchild of 0008112
2024-03-07 19:47Christian GrothoffStatusinforming => closed