View Issue Details

IDProjectCategoryView StatusLast Update
0008070Talerexchangepublic2024-03-07 19:49
Reporterfefe Assigned Tooec Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008070: perform_protocol: leaks hash context
DescriptionThis is in exchange/src/lib/exchange_api_age_withdraw.c:

   511 struct GNUNET_HashContext *coins_hctx;

   545 coins_hctx = GNUNET_CRYPTO_hash_context_start ();
   546 FAIL_IF (NULL == coins_hctx);

Internally, this allocates a context and calls gcry_md_open on stuff in it.

   596 GNUNET_CRYPTO_hash_context_read (coins_hctx,
   597 &bch,
   598 sizeof(bch));
   599 }
   600
   601 FAIL_IF (0 < json_array_append_new (j_array_candidates,
   602 j_can));

Aside from the fail condition being wrong here (see other bug) this is supposed to do a goto FAIL, in which case coins_hctx leaks.
After FAIL: add a GNUNET_CRYPTO_hash_context_abort(coins_hctx).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

oec

2024-01-12 10:59

developer   ~0020870

Fixed with a6b35ee7d345aa11e0388733fb95f3a4d2e52180

Issue History

Date ModifiedUsernameFieldChange
2024-01-11 16:15fefeNew Issue
2024-01-11 16:15fefeStatusnew => assigned
2024-01-11 16:15fefeAssigned To => Christian Grothoff
2024-01-11 16:17oecAssigned ToChristian Grothoff => oec
2024-01-12 10:59oecStatusassigned => informing
2024-01-12 10:59oecResolutionopen => fixed
2024-01-12 10:59oecFixed in Version => git (master)
2024-01-12 10:59oecNote Added: 0020870
2024-01-25 21:29Christian GrothoffFixed in Versiongit (master) => 0.9.4
2024-01-25 21:29Christian GrothoffTarget Version => 0.9.4
2024-03-07 19:49Christian GrothoffStatusinforming => closed