View Issue Details

IDProjectCategoryView StatusLast Update
0008069Talerauditorpublic2024-03-07 19:49
Reporterfefe Assigned Tooec Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008069: perform_protocol: wrong fail check
DescriptionThis is in exchange/src/lib/exchange_api_age_withdraw.c:

   570 FAIL_IF (0 < json_array_append_new (j_denoms,
   571 jdenom));

According to the jansson API reference, json_array_append_new returns 0 on success and -1 on error.
This check looks for positive return values, which cannot happen.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

fefe

2024-01-11 16:01

reporter   ~0020863

Oops sorry this should be exchange not auditor (according to the filename) There is also several more occurrances of this pattern in the same file.

oec

2024-01-12 10:59

developer   ~0020869

Fixed with a6b35ee7d345aa11e0388733fb95f3a4d2e52180

Issue History

Date ModifiedUsernameFieldChange
2024-01-11 15:59fefeNew Issue
2024-01-11 15:59fefeStatusnew => assigned
2024-01-11 15:59fefeAssigned To => Christian Grothoff
2024-01-11 16:01fefeNote Added: 0020863
2024-01-11 16:14oecAssigned ToChristian Grothoff => oec
2024-01-12 10:59oecStatusassigned => informing
2024-01-12 10:59oecResolutionopen => fixed
2024-01-12 10:59oecFixed in Version => git (master)
2024-01-12 10:59oecNote Added: 0020869
2024-01-25 21:30Christian GrothoffFixed in Versiongit (master) => 0.9.4
2024-01-25 21:30Christian GrothoffTarget Version => 0.9.4
2024-03-07 19:49Christian GrothoffStatusinforming => closed