View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008054 | Taler | auditor | public | 2024-01-10 13:40 | 2024-03-07 19:47 |
| Reporter | fefe | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.9.4 | Fixed in Version | 0.9.4 | ||
| Summary | 0008054: handle_exchanges_finished: integer truncation | ||||
| Description | This is in exchange/src/lib/auditor_api_exchanges.c: 79 static void 80 handle_exchanges_finished (void *cls, 81 long response_code, 82 const void *djson) 83 { 84 const json_t *json = djson; 85 const json_t *ja; 86 unsigned int ja_len; This should be size_t instead of unsigned int. 111 ja_len = json_array_size (ja); 112 if (ja_len > MAX_EXCHANGES) 113 { 114 GNUNET_break (0); 115 ler.hr.ec = TALER_EC_GENERIC_REPLY_MALFORMED; 116 ler.hr.http_status = 0; 117 break; 118 } json_array_size() returns size_t, so the assignment to ja_len here potentially truncates the value, leading to logic errors. | ||||
| Tags | No tags attached. | ||||
| Nice one, but: this endpoint is actually being removed, as we're killing multi-tenant support in the exchange. So I'll fix it by killing the code ;-). | |
| Fixed in 68ced6e3..fcce372a | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-10 13:40 | fefe | New Issue | |
| 2024-01-10 13:40 | fefe | Status | new => assigned |
| 2024-01-10 13:40 | fefe | Assigned To | => Christian Grothoff |
| 2024-01-10 13:43 | Christian Grothoff | Note Added: 0020856 | |
| 2024-01-10 13:52 | Christian Grothoff | Status | assigned => informing |
| 2024-01-10 13:52 | Christian Grothoff | Resolution | open => fixed |
| 2024-01-10 13:52 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2024-01-10 13:52 | Christian Grothoff | Note Added: 0020857 | |
| 2024-01-10 13:52 | Christian Grothoff | Product Version | => git (master) |
| 2024-01-10 13:52 | Christian Grothoff | Target Version | => 0.9.4 |
| 2024-01-18 22:33 | Christian Grothoff | Relationship added | child of 0008112 |
| 2024-03-07 19:47 | Christian Grothoff | Status | informing => closed |