View Issue Details

IDProjectCategoryView StatusLast Update
0008044GNUnetutil librarypublic2024-03-07 19:26
Reporterfefe Assigned ToChristian Grothoff Due Date
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Fixed in Version0.21.0 
Summary0008044: parse_fixed_data: integer overflow
DescriptionThis is in gnunet/src/lib/json/json_helper.c.

  52 static enum GNUNET_GenericReturnValue
  53 parse_fixed_data (void *cls,
  54 json_t *root,
  55 struct GNUNET_JSON_Specification *spec)
  56 {
  57 const char *enc;
  58 unsigned int len;
  59
  60 if (NULL == (enc = json_string_value (root)))
  61 {
  62 GNUNET_break_op (0);
  63 return GNUNET_SYSERR;
  64 }
  65 len = strlen (enc);
  66 if (((len * 5) / 8) != spec->ptr_size)
  67 {

len should be a size_t instead of an int, and the * 5 can overflow even after turning len into a size_t.
TagsNo tags attached.

Activities

Christian Grothoff

2024-01-09 18:11

manager   ~0020846

Fix committed to master branch.

schanzen

2024-03-07 19:26

administrator   ~0021802

0.21 released

Issue History

Date ModifiedUsernameFieldChange
2024-01-09 14:24fefeNew Issue
2024-01-09 18:11Christian Grothoff
2024-01-09 18:11Christian GrothoffNote Added: 0020846
2024-01-09 18:11Christian GrothoffAssigned To => Christian Grothoff
2024-01-09 18:11Christian GrothoffStatusnew => resolved
2024-01-09 18:11Christian GrothoffResolutionopen => fixed
2024-01-09 19:10Christian GrothoffProjectTaler => GNUnet
2024-01-09 19:10Christian GrothoffCategoryother => util library
2024-03-07 19:26schanzenFixed in Version => 0.21.0
2024-03-07 19:26schanzenNote Added: 0021802
2024-03-07 19:26schanzenStatusresolved => closed