View Issue Details

IDProjectCategoryView StatusLast Update
0008019Talerexchangepublic2024-03-07 19:47
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008019: taler-terms-generator does not respect file system hierarchy standard
DescriptionThe Debian package installs the sample ToS files in /usr/share/taler/terms. That is completely fine.

However, the taler-terms-generator then generates files based on that also in /usr/share/taler/terms. That violates the file system hierarchy standard, because /usr/share is supposed to be read-only. Instead, the ToS should be served from /etc/taler/terms or /var/lib/taler/terms.

While this sounds like nitpicking, it has caused real issues before: Sandcastle-ng mounts /usr/share/taler/terms as a volume, so the results of taler-terms-generator can be cached between runs. But this also means that newer versions of the sample ToS shipped with the package will not be picked up.

Furthermore, the current path encourages users to make modifications that then will be overwritten by package updates. We should not mix up immutable data that is shipped with the package and generated or user-modified files!
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2023-12-22 06:36

manager   ~0020787

Should be fixed with 5c3c1b68..afdccca7

Issue History

Date ModifiedUsernameFieldChange
2023-12-20 08:42Florian DoldNew Issue
2023-12-20 08:42Florian DoldStatusnew => assigned
2023-12-20 08:42Florian DoldAssigned To => Christian Grothoff
2023-12-22 06:36Christian GrothoffNote Added: 0020787
2023-12-22 06:36Christian GrothoffStatusassigned => informing
2023-12-22 06:36Christian GrothoffResolutionopen => fixed
2023-12-22 06:37Christian GrothoffProduct Version => git (master)
2023-12-22 06:37Christian GrothoffFixed in Version => 0.9.4
2024-03-07 19:47Christian GrothoffStatusinforming => closed