View Issue Details

IDProjectCategoryView StatusLast Update
0008016Talerwallet-corepublic2024-04-15 19:32
ReporterFlorian Dold Assigned ToMarcS Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.10Fixed in Version0.10 
Summary0008016: review balance-changed notification and pending incoming amounts
DescriptionOn withdrawal, wallet-core sometimes does not seem to emit balance-changed notifications.

Also, the pending incoming balance is not decreased accordingly.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-12-19 17:51

manager   ~0020781

@MarcS: Can you provide some context when this happens?

Also, I'm not sure about pending incoming: Wallet-core only updates the balance when a withdrawal has entered a final state. This is why finished batches should not update the balance at all until either all batches succeeded or the withdrawal gets aborted.

Note that multiple batches are very rare in the first place and should not occur in practice.

MarcS

2024-04-08 14:32

developer   ~0022154

Problem was, that wallet-core sent balance-changed too early (before the DB was updated). This should be fixed by fdold already weeks ago. Also, I cached the notification and now call getBalances when the withdrawal confirmation dialog is dismissed and the balances view is shown.

Issue History

Date ModifiedUsernameFieldChange
2023-12-19 17:49Florian DoldNew Issue
2023-12-19 17:49Florian DoldStatusnew => assigned
2023-12-19 17:49Florian DoldAssigned To => Florian Dold
2023-12-19 17:51Florian DoldAssigned ToFlorian Dold => MarcS
2023-12-19 17:51Florian DoldStatusassigned => feedback
2023-12-19 17:51Florian DoldNote Added: 0020781
2024-01-15 19:46Christian GrothoffTarget Version0.9.4 => 0.10
2024-04-08 14:32MarcSStatusfeedback => informing
2024-04-08 14:32MarcSResolutionopen => fixed
2024-04-08 14:32MarcSFixed in Version => 0.9.4
2024-04-08 14:32MarcSNote Added: 0022154
2024-04-09 11:12Christian GrothoffFixed in Version0.9.4 => 0.10
2024-04-15 19:32Christian GrothoffStatusinforming => closed