View Issue Details

IDProjectCategoryView StatusLast Update
0008003Talerexchangepublic2024-03-07 19:47
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.4Fixed in Version0.9.4 
Summary0008003: tos generator generates invalid markdown
DescriptionThe ToS generator generates markdown with headings like this:

"""
Terms of Service
****
"""

As far as I can see, no commonly used markdown specification allows this syntax.

This style of headings breaks markdown rendering on iOS.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0007994 closedFlorian Dold wallet-core and UIs should support i18n-ized terms of service 
related to 0007882 closedsebasjm ToS is always text/plain, even if you ask for text/markdown only 

Activities

MarcS

2023-12-11 18:57

developer   ~0020739

Last edited: 2023-12-11 18:59

More Problems:
Exhibit: "You are responsible for keeping the data in your Taler Wallet at all\n times\n under your control"
1) Single line breaks are ignored, but the two spaces after the first \n and the five spaces after the second are rendered and lead to "holes" in the text.

Christian Grothoff

2023-12-13 04:41

manager   ~0020747

a14e263a..547f2ea0 fixes this. You do need to do something like pip3 install sphinx-markdown-builder though...

Issue History

Date ModifiedUsernameFieldChange
2023-12-11 10:41Florian DoldNew Issue
2023-12-11 10:41Florian DoldStatusnew => assigned
2023-12-11 10:41Florian DoldAssigned To => Christian Grothoff
2023-12-11 12:41MarcSRelationship addedrelated to 0007994
2023-12-11 12:41MarcSRelationship addedrelated to 0007882
2023-12-11 18:57MarcSNote Added: 0020739
2023-12-11 18:59MarcSNote Edited: 0020739
2023-12-13 04:41Christian GrothoffNote Added: 0020747
2023-12-13 04:41Christian GrothoffStatusassigned => informing
2023-12-13 04:41Christian GrothoffResolutionopen => fixed
2023-12-13 04:41Christian GrothoffFixed in Version => 0.9.4
2024-03-07 19:47Christian GrothoffStatusinforming => closed