View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007969 | Taler | wallet-core | public | 2023-10-26 12:50 | 2023-11-29 00:30 |
| Reporter | MarcS | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.9.4 | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007969: When the server is down, wallet-core shouldn't throw a JSON error from downloadExchangeKeysInfo | ||||
| Description | Possibly unhandled promise rejection: Error: Couldn't parse JSON format from error response at TalerError (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12095) at fromDetail (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12104) at readTalerErrorResponse (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12471) at readSuccessResponseJsonOrErrorCode (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12515) at readSuccessResponseJsonOrThrow (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:12561) at downloadExchangeKeysInfo (/Users/ms/Developer/gnuTaler/quickjs-tart/taler-wallet-core-qjs.mjs:25907) | ||||
| Tags | No tags attached. | ||||
| Not sure what we should do here, as the server *gives* us a response, and it's not valid JSON. The server (exchange) is down, but the reverse proxy (nginx) still gives us a valid HTTP response. I guess we could be stricter with the response handling: If the response headers don't indicate it's JSON, we don't parse it and instead report that the server did not even respond with JSON. @MarcS: Would that fix this bug for you or do you think something entirely different should happen here? | |
| Fixed in wallet-core.git:342df60a. We now give a better error message when the error response didn't even contain JSON. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-10-26 12:50 | MarcS | New Issue | |
| 2023-10-26 12:50 | MarcS | Status | new => assigned |
| 2023-10-26 12:50 | MarcS | Assigned To | => Florian Dold |
| 2023-11-14 12:57 | Florian Dold | Status | assigned => feedback |
| 2023-11-14 12:57 | Florian Dold | Note Added: 0020640 | |
| 2023-11-14 13:00 | Florian Dold | Assigned To | Florian Dold => MarcS |
| 2023-11-15 11:11 | Florian Dold | Assigned To | MarcS => Florian Dold |
| 2023-11-21 10:52 | Florian Dold | Status | feedback => informing |
| 2023-11-21 10:52 | Florian Dold | Resolution | open => fixed |
| 2023-11-21 10:52 | Florian Dold | Note Added: 0020653 | |
| 2023-11-29 00:28 | Christian Grothoff | Target Version | 0.9.4 => 0.9.3 |
| 2023-11-29 00:29 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-11-29 00:30 | Christian Grothoff | Status | informing => closed |