View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007934 | Taler | exchange | public | 2023-09-05 09:51 | 2023-11-29 00:30 |
| Reporter | javier.sepulveda | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.9.4 | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007934: ToS program, can't be executed from anywhere but from the .rst file is located + Other improvents | ||||
| Description | Program: taler-terms-generator https://git.taler.net/exchange.git/tree/contrib/taler-terms-generator.in ### When using the taler-terms-generator program from the outside of the $TOS_PATH (check in deployment.git/sandcastle: docker-compose.yml + images/exchange/scripts/startup.sh), it doesn't work. cd $TOS_PATH taler-terms-generator -i file # works taler-terms-generator -i /path/to/file # doesn't work Proposed improvement: ------------------------ 1) Include the ".rst" type file, as part of the file name. i.e : taler-terms-generator -i file.rst 2) Please check line 29 For the sake of readability, maybe it is better to use the equal symbol as delimiter, instead of a slash symbol : 's=/=\\/=g' | ||||
| Tags | No tags attached. | ||||
| 3fa3a7da..74c56c62 modifies the code to make it run from any location. I don't see the need to fix the sed-escaping, but also don't fundamentally oppose. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-09-05 09:51 | javier.sepulveda | New Issue | |
| 2023-09-05 09:51 | javier.sepulveda | Status | new => assigned |
| 2023-09-05 09:51 | javier.sepulveda | Assigned To | => Christian Grothoff |
| 2023-09-29 11:31 | Christian Grothoff | Note Added: 0020561 | |
| 2023-09-29 11:31 | Christian Grothoff | Status | assigned => informing |
| 2023-09-29 11:31 | Christian Grothoff | Resolution | open => fixed |
| 2023-09-29 11:31 | Christian Grothoff | Fixed in Version | => 0.9.4 |
| 2023-09-29 11:31 | Christian Grothoff | Target Version | => 0.9.4 |
| 2023-11-29 00:28 | Christian Grothoff | Target Version | 0.9.4 => 0.9.3 |
| 2023-11-29 00:29 | Christian Grothoff | Fixed in Version | 0.9.4 => 0.9.3 |
| 2023-11-29 00:30 | Christian Grothoff | Status | informing => closed |