View Issue Details

IDProjectCategoryView StatusLast Update
0007896Talerdeployment and operationspublic2024-03-07 19:47
Reportersebasjm Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.4Fixed in Version0.9.4 
Summary0007896: taler-config overrides the template configuration under /etc/taler/taler.conf
DescriptionI happen several times, that after using the cli
taler-config -s <section> -o <option> -V <value>

I found that the content of the /etc/taler/taler.conf doesn't have the reference to the conf.d files.

In the same direction, when taler-config fails because of permissions problems it does it quietly (doesn't print anything). Error code is not 0 but from the user it looks like it when normally.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2023-08-02 21:24

manager   ~0020398

Well, we can't really fix it overriding taler.conf, that's why the documentation urges you to not use it for editing configuration files.

We should of course fix the error reporting on failures, I'll look into that.

Christian Grothoff

2023-08-03 16:44

manager   ~0020406

$ touch foo
$ chmod 400 foo
grothoff@pixel:~/research/taler/docs$ taler-config -c foo -s bla -o blub -V var
2023-08-03T18:43:16.081130+0200 util-disk-210646 WARNING `open' failed on file `/home/grothoff/research/taler/docs/foo' at disk.c:1291 with error: Permission denied
grothoff@pixel:~/research/taler/docs$ echo $?
2

Error reporting looks fine to me, can you please give me an idea how to reproduce the issue?

sebasjm

2023-12-22 14:43

developer   ~0020793

following the documentation to install the deb and then doing some

# taler-config -c /etc/taler/taler.conf -s fck -o up -V the_file

which looks pretty innocent and since the package comes with a tool to modify the config it is expected to not break the config system.

After running it all the inline directives are removed (which brings unexpected problems) and falling into this issue doesn't have a easy rollback.

The correct behavior should be "editing the property if exist in the file otherwise append the section/property at end" but it is also good enough to report an error "not yet implemented"

Christian Grothoff

2023-12-25 18:24

manager   ~0020811

47a153af..3a62b34f removes all dangerous incantations of taler-config from the manuals. The few places that explain "-V" come with adequate warnings.

Issue History

Date ModifiedUsernameFieldChange
2023-08-01 18:50sebasjmNew Issue
2023-08-01 18:50sebasjmStatusnew => assigned
2023-08-01 18:50sebasjmAssigned To => Christian Grothoff
2023-08-02 21:24Christian GrothoffNote Added: 0020398
2023-08-03 16:44Christian GrothoffNote Added: 0020406
2023-08-03 16:44Christian GrothoffAssigned ToChristian Grothoff => sebasjm
2023-08-03 16:44Christian GrothoffStatusassigned => feedback
2023-12-22 13:36Christian GrothoffTarget Versiongit (master) => post-1.0
2023-12-22 14:43sebasjmNote Added: 0020793
2023-12-22 14:44sebasjmAssigned Tosebasjm => Christian Grothoff
2023-12-25 18:24Christian GrothoffStatusfeedback => informing
2023-12-25 18:24Christian GrothoffResolutionopen => fixed
2023-12-25 18:24Christian GrothoffFixed in Version => 0.9.4
2023-12-25 18:24Christian GrothoffNote Added: 0020811
2023-12-25 18:24Christian GrothoffProduct Version0.11 => git (master)
2023-12-25 18:24Christian GrothoffTarget Versionpost-1.0 => 0.9.4
2024-03-07 19:47Christian GrothoffStatusinforming => closed