View Issue Details

IDProjectCategoryView StatusLast Update
0007818Talerwallet-corepublic2023-11-29 00:30
ReporterMarcS Assigned ToMarcS Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007818: fractionalBaseDigits of currencies
DescriptionMost currencies in the world have two digits after the decimal point/comma - but some have three (most arabian countries: Bahraini Dinar, Iraqi Dinar, Jordanian Dinar, Kuwaiti Dinar, Libyan Dinar, Rial Omani, Tunisian Dinar) and some have none (Indonesian Rupiah, Japanese Yen, South-Korean Won, Vietnamese New Dong, Cape Verdi Escudo, Paraguay Guarani, and a few african and caribbean countries).

When querying for exchanges, the data returned should not only tell the name of the currency:
    var exchangeBaseUrl: String
    var currency: String?
but also the fractionalBaseDigits:
    var fractionalBaseDigits: UInt?

There are 3 possible wallet-core calls where that information could be returned:
1) ListExchangesOp
2) GetExchangeDetailedInfoOp
3) ListCurrenciesOp

Sebastian wrote about using denominations to find out what amount might be possible to send, but fractionalBaseDigits are needed to display amounts correctly in balances and transaction views, especially whole numbers which might still need to be shown with decimal delimiter and fractional digits (.00, .000, ...).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-11-14 13:02

manager   ~0020641

@MarcS: This looks like it's already covered by the currency spec, right?

MarcS

2023-11-14 13:29

developer   ~0020642

This is covered in DD51.

Issue History

Date ModifiedUsernameFieldChange
2023-04-24 05:49MarcSNew Issue
2023-04-24 05:49MarcSStatusnew => assigned
2023-04-24 05:49MarcSAssigned To => Florian Dold
2023-08-24 14:27Florian DoldProduct Versionpost-1.0 => git (master)
2023-08-24 14:27Florian DoldTarget Versionpost-1.0 => 0.9.4
2023-11-14 13:02Florian DoldAssigned ToFlorian Dold => MarcS
2023-11-14 13:02Florian DoldStatusassigned => feedback
2023-11-14 13:02Florian DoldNote Added: 0020641
2023-11-14 13:29MarcSStatusfeedback => informing
2023-11-14 13:29MarcSResolutionopen => fixed
2023-11-14 13:29MarcSNote Added: 0020642
2023-11-29 00:28Christian GrothoffTarget Version0.9.4 => 0.9.3
2023-11-29 00:29Christian GrothoffFixed in Version => 0.9.3
2023-11-29 00:30Christian GrothoffStatusinforming => closed