View Issue Details

IDProjectCategoryView StatusLast Update
0007810Talerwallet-corepublic2023-11-29 00:30
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityurgentSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007810: support conversion service URL and regex validation for /wire
DescriptionWe also need to distinguish between withdrawals and deposits, as in the conversion case, different restrictions for the payto:// URI apply.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2023-04-22 20:08

manager   ~0020126

Last edited: 2023-04-22 20:09

API change for /wire specified in docs.git -- 43a3dca..d3102b7.

Once implemented, we MUST bump the protocol to "15:0:0" and add a (transient) protocol-version based switch in libtalerexchange.

Christian Grothoff

2023-05-02 10:09

manager   ~0020172

This is largely implemented (exchange, merchant, documentation). Wallet is missing (=> assigning to Florian). What is still missing is that the merchant (and wallet) currently ignores debit restrictions imposed by the exchange and would be perfectly happy to accept deposits for coins from exchanges where the exchange doesn't actually accept the merchant's bank account.

To fix this, we need a working regex evaluator for this style of regex AND to modify the pay logic to actually check.

Florian Dold

2023-11-22 17:21

manager   ~0020657

In wallet-core, we now support:
* using the conversion_url during (manual only!) withdrawal, allowing the UIs to display the external currency that the user needs to transfer to withdraw the regional currency
* checking the debit restrictions on deposit

However, obviously the wallet can't check deposit restrictions when doing a payment, since it doesn't know the payto URI of the merchant.
What was the design here? I remember we discussed *something* here, but not sure what it was exactly anymore.

Florian Dold

2023-11-22 17:28

manager   ~0020658

(After giving it more thought, I think that the merchant must only include exchanges in the contract terms where the merchant account is allowed by the debit restrictions of the exchange.)

Christian Grothoff

2023-11-22 19:04

manager   ~0020659

Yes, and the merchant does so. Why did you re-assign to me?

Issue History

Date ModifiedUsernameFieldChange
2023-04-22 15:54Florian DoldNew Issue
2023-04-22 15:54Florian DoldStatusnew => assigned
2023-04-22 15:54Florian DoldAssigned To => Christian Grothoff
2023-04-22 16:11Florian DoldDescription Updated
2023-04-22 20:08Christian GrothoffNote Added: 0020126
2023-04-22 20:09Christian GrothoffNote Edited: 0020126
2023-05-02 10:09Christian GrothoffNote Added: 0020172
2023-05-02 10:09Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2023-06-21 16:22Florian DoldTarget Version0.9.3 => 0.9.4
2023-07-16 14:05Christian GrothoffPrioritynormal => urgent
2023-11-02 23:40Christian GrothoffCategoryexchange => wallet-core
2023-11-13 17:39Florian DoldAssigned ToFlorian Dold => Christian Grothoff
2023-11-13 17:39Florian DoldAssigned ToChristian Grothoff => Florian Dold
2023-11-22 17:19Florian DoldAssigned ToFlorian Dold => Christian Grothoff
2023-11-22 17:21Florian DoldNote Added: 0020657
2023-11-22 17:28Florian DoldNote Added: 0020658
2023-11-22 19:04Christian GrothoffNote Added: 0020659
2023-11-22 19:15Christian GrothoffStatusassigned => informing
2023-11-22 19:15Christian GrothoffResolutionopen => fixed
2023-11-22 19:15Christian GrothoffFixed in Version => 0.9.4
2023-11-29 00:28Christian GrothoffTarget Version0.9.4 => 0.9.3
2023-11-29 00:29Christian GrothoffFixed in Version0.9.4 => 0.9.3
2023-11-29 00:30Christian GrothoffStatusinforming => closed