View Issue Details

IDProjectCategoryView StatusLast Update
0007761Talerwallet-corepublic2023-09-23 13:09
Reportersebasjm Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007761: coin spend is not rollback after deposit failed
Descriptionhere [1] after, if the deposit failed then the error is not catch and the coin remains dormant
an example of exchange error can be found here [2], the iban was wrong and the exchange return 400

from the ui looks like the money is lost


[1] https://git.taler.net/wallet-core.git/tree/packages/taler-wallet-core/src/operations/deposits.ts#n182
[2] https://bugs.gnunet.org/view.php?id=7760
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-03-30 09:29

manager   ~0019993

I'm counting this towards the D37 work, the money should be restored when aborting the transaction!

Florian Dold

2023-06-05 12:01

manager   ~0020259

Aborting a deposit transaction now does a refund+refresh, so money isn't lost anymore.

I've tested this with the CLI wallet.

Issue History

Date ModifiedUsernameFieldChange
2023-03-09 14:47sebasjmNew Issue
2023-03-09 14:47sebasjmStatusnew => assigned
2023-03-09 14:47sebasjmAssigned To => Florian Dold
2023-03-30 09:28Florian DoldTarget Version0.9.2 => 0.9.3
2023-03-30 09:29Florian DoldNote Added: 0019993
2023-04-13 18:36Florian DoldCategorywallet (TS core) => wallet-core
2023-06-05 12:01Florian DoldStatusassigned => informing
2023-06-05 12:01Florian DoldResolutionopen => fixed
2023-06-05 12:01Florian DoldNote Added: 0020259
2023-09-23 13:07Christian GrothoffFixed in Version => 0.9.3
2023-09-23 13:09Christian GrothoffStatusinforming => closed