View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007747 | Taler | exchange | public | 2023-03-07 12:13 | 2023-09-23 13:09 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007747: sample exchange ToS HTML is giant | ||||
| Description | For some reason, the ToS converted to HTML is unacceptable large (>600KB), when it is just simple, plain text. It is so large, that it doesn't fit into one Android IPC message (with JSON encoding/escaping overhead) | ||||
| Tags | No tags attached. | ||||
| Why does the Android wallet request the HTML version? It is so huge as it packs various JS+CSS to make it render nicely. The Android wallet should be asking for RST or TXT, not HTML! | |
| One issue is that the exchange returns the giant HTML response *by default*, either when no "Accept:" header is specified, or there is no match for the requested content type. But I currently don't understand why wallet-core is not requesting either "text/plain" or "text/markdown", I'll have to look into this. | |
| Okay, so I've fixed a bug in qtart that caused *duplicate* "Accept: application/json" and "Accept: text/plain" headers to be added, which was clearly wrong. However, I still think it's bad behavior of the exchange to default to returning HTML when there is no matching ToS for the requested MIME type or no Accept header was given. | |
| Well, what do you think should be the default? HTML is usually the default for the Web, but I guess we could default to text/plain as well... | |
| cbabddf0..677ac4a5 changes the default to text/plain. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-03-07 12:13 | Florian Dold | New Issue | |
| 2023-03-07 12:13 | Florian Dold | Status | new => assigned |
| 2023-03-07 12:13 | Florian Dold | Assigned To | => Christian Grothoff |
| 2023-03-07 12:17 | Christian Grothoff | Note Added: 0019924 | |
| 2023-03-07 12:17 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2023-03-07 12:17 | Christian Grothoff | Status | assigned => feedback |
| 2023-03-28 18:20 | Florian Dold | Note Added: 0019985 | |
| 2023-03-29 19:01 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2023-03-29 19:01 | Florian Dold | Status | feedback => assigned |
| 2023-03-29 19:01 | Florian Dold | Note Added: 0019989 | |
| 2023-03-30 01:11 | Christian Grothoff | Note Added: 0019991 | |
| 2023-04-08 07:46 | Christian Grothoff | Note Added: 0020039 | |
| 2023-04-08 07:46 | Christian Grothoff | Status | assigned => informing |
| 2023-04-08 07:46 | Christian Grothoff | Resolution | open => fixed |
| 2023-04-08 07:46 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 13:09 | Christian Grothoff | Status | informing => closed |