View Issue Details

IDProjectCategoryView StatusLast Update
0007746Talerwallet (Android App)public2023-09-23 13:09
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007746: Android wallet is rather fussy about which ToS it renders
DescriptionEven with well-formed markdown, the Android wallet often refuses to render it.

If the ToS doesn't have the structure that the wallet expects, it should at least try to render it instead of completely refusing.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

grote

2023-03-21 21:16

reporter   ~0019973

Florian, is this assigned to you intentionally? AFAIK the wallet is following what we had discussed for an expected Rest/Markdown structure in the past.If we just render whatever, exchanges are not incentivized to follow our best practices.

Florian Dold

2023-03-28 16:02

manager   ~0019979

Nope, that was unintentional.

Florian Dold

2023-03-28 16:02

manager   ~0019980

Do we have this documented somewhere, at least in a design document?

grote

2023-03-28 16:11

reporter   ~0019981

Fuzzyness is document in https://docs.taler.net/design-documents/003-tos-rendering.html

> The text/markdown document should follow the commonmark spec. Main headlines (level 1) and their following content (until the next main headline) will be shown as expandable sections in wallets.

Florian Dold

2023-04-04 09:53

manager   ~0020005

Turns out that this is the ToS format that we've agreed on.

The exchange or at least some lint tool should check the ToS markdown syntax though, see 0007780:

Issue History

Date ModifiedUsernameFieldChange
2023-03-07 12:11Florian DoldNew Issue
2023-03-07 12:11Florian DoldStatusnew => assigned
2023-03-07 12:11Florian DoldAssigned To => Florian Dold
2023-03-21 21:16groteNote Added: 0019973
2023-03-28 16:01Florian DoldAssigned ToFlorian Dold => grote
2023-03-28 16:02Florian DoldNote Added: 0019979
2023-03-28 16:02Florian DoldNote Added: 0019980
2023-03-28 16:11groteNote Added: 0019981
2023-03-28 16:35groteAssigned Togrote => Florian Dold
2023-03-28 16:35groteStatusassigned => feedback
2023-04-04 09:53Florian DoldStatusfeedback => informing
2023-04-04 09:53Florian DoldResolutionopen => fixed
2023-04-04 09:53Florian DoldNote Added: 0020005
2023-09-23 13:07Christian GrothoffFixed in Version => 0.9.3
2023-09-23 13:09Christian GrothoffStatusinforming => closed