View Issue Details

IDProjectCategoryView StatusLast Update
0007730Talerlibeufin-bank webuipublic2023-09-23 13:09
ReporterFlorian Dold Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionno change required 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007730: demobank-ui should clear client state when server config has changed
DescriptionWe can easily detect this by storing a hash of the config.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2023-02-28 11:26

developer   ~0019908

waiting for 0007527

Florian Dold

2023-03-05 15:00

manager   ~0019921

I don't think this is related to 0007527. This bug is about the configuration for the *ui* exclusively (which backend to use), and that is orthogonal to the LibEuFin configuration.

sebasjm

2023-03-05 18:52

developer   ~0019922

> when server config has changed

ACK, this confuses me. Then it should be the UI settings like backendBaseURL or allowRegistrations. Right?
and not about the /config values of the backend. Like fee rates.

Florian Dold

2023-03-05 19:32

manager   ~0019923

Yes, exactly. It's *only* about globalThis.talerDemobankSettings, which are typically set in demobank-ui-settings.js.

The problem is, right now, when these settings change, it often has no effect until localStorage is cleared.

sebasjm

2023-03-27 17:09

developer   ~0019978

I don't think this is needed now.

All the settings is read from the config file and the config file and it's not cached in the local storage as whole.
The only attribute that is being cached is `bankUiSettings.backendBaseURL` with the local storage key `bank-base-url` which is not exposed in the UI. The only way to override the value is manually using the development tool from the browser.

This was not the case with older version of the SPA, which used local storage for extensively.

Issue History

Date ModifiedUsernameFieldChange
2023-02-26 16:32Florian DoldNew Issue
2023-02-26 16:32Florian DoldStatusnew => assigned
2023-02-26 16:32Florian DoldAssigned To => sebasjm
2023-02-28 11:25sebasjmRelationship addedrelated to 0007527
2023-02-28 11:26sebasjmNote Added: 0019908
2023-03-05 14:59Florian DoldPrioritynormal => high
2023-03-05 15:00Florian DoldNote Added: 0019921
2023-03-05 18:51sebasjmRelationship deletedrelated to 0007527
2023-03-05 18:52sebasjmNote Added: 0019922
2023-03-05 19:32Florian DoldNote Added: 0019923
2023-03-27 17:09sebasjmStatusassigned => informing
2023-03-27 17:09sebasjmResolutionopen => no change required
2023-03-27 17:09sebasjmNote Added: 0019978
2023-09-23 13:07Christian GrothoffFixed in Version => 0.9.3
2023-09-23 13:09Christian GrothoffStatusinforming => closed
2023-12-03 00:21Christian GrothoffCategorydemobank-ui => libeufin-bank-ui
2024-01-12 13:10Christian GrothoffCategorylibeufin-bank-ui => libeufin-bank-ui (SPA)
2026-08-23 14:18Florian DoldCategorylibeufin-bank-ui (SPA) => libeufin-bank webui