View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007728 | Taler | wallet (Android App) | public | 2023-02-24 18:58 | 2023-09-23 13:09 |
| Reporter | Florian Dold | Assigned To | avalos | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007728: "confirm with bank" button stays in transaction history even when withdrawal is complete | ||||
| Description | Something is not updated correctly here. | ||||
| Tags | No tags attached. | ||||
| What do you mean by “transaction history”? The transactions list? As far as I know, the “confirm with bank” button hasn't been merged there yet. Currently, it is only present in the transaction details. | |
| Nevermind, the “confirm with bank” button was already merged. However, there's a pending refactoring of the button. Now I'm using a Jetpack composable for the button, and it has improved logic. | |
| I can confirm that the new composable action button is updating correctly. | |
| @avalos do we need to merge anything to resolve this? Are composable versions of this button strictly needed for the fix? @florian I remember that Christian wasn't so keen on having that button in the transaction list at all. Maybe easier to just remove it? | |
| Decided today on Mumble: We leave out the button in the transaction list. Instead we show a badge, ideally based on the state and substate when DD37 support is available in wallet-core. | |
| I removed the action button from the transaction list in dev/ivan-avalos/master, please give it a check. I still think it would be a good idea to put the composable action button in the transaction details, as it has a more flexible handling of user actions, and it won't affect performance noticeably in the release version, as things are significantly optimized. | |
| Buttons was removed in c2283c02428005a8ce0dc00df72535e27f7892d9 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-02-24 18:58 | Florian Dold | New Issue | |
| 2023-02-24 18:58 | Florian Dold | Status | new => assigned |
| 2023-02-24 18:58 | Florian Dold | Assigned To | => avalos |
| 2023-02-28 16:15 | avalos | Note Added: 0019910 | |
| 2023-02-28 16:20 | avalos | Note Added: 0019911 | |
| 2023-02-28 16:35 | avalos | Note Added: 0019912 | |
| 2023-03-21 21:18 | grote | Note Added: 0019974 | |
| 2023-04-04 16:26 | Florian Dold | Note Added: 0020016 | |
| 2023-04-10 06:39 | avalos | Note Added: 0020043 | |
| 2023-04-10 20:45 | grote | Status | assigned => informing |
| 2023-04-10 20:45 | grote | Resolution | open => fixed |
| 2023-04-10 20:45 | grote | Note Added: 0020057 | |
| 2023-09-23 13:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 13:09 | Christian Grothoff | Status | informing => closed |