View Issue Details

IDProjectCategoryView StatusLast Update
0007702Talerwallet-corepublic2023-02-21 15:39
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityurgentSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.2Fixed in Version0.9.2 
Summary0007702: amountEffective sometimes missing in peer push transactions
DescriptionReported by Christian to have occurred during some Bitcoin p2p transfer, when the exchange was not available (?).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-02-19 13:26

manager   ~0019881

This is not possible with the current version of the wallet anymore. It is possible that an old wallet contains a transaction without the amountEffective.

I've checked the code, and the amountEffective is always taken directly from the wallet DB, and when writing the PeerPushPaymentInitiationRecord, the amount can't be null or undefined.

I've also tested it manually with an exchange that was taken offline when doing then push payment initiation and then resumed on a second attempt, and never was the amountEffective missing.

Issue History

Date ModifiedUsernameFieldChange
2023-02-17 12:08Florian DoldNew Issue
2023-02-17 12:08Florian DoldStatusnew => assigned
2023-02-17 12:08Florian DoldAssigned To => Florian Dold
2023-02-19 13:26Florian DoldStatusassigned => informing
2023-02-19 13:26Florian DoldResolutionopen => fixed
2023-02-19 13:26Florian DoldNote Added: 0019881
2023-02-21 15:39Christian GrothoffFixed in Version => 0.9.2
2023-02-21 15:39Christian GrothoffStatusinforming => closed
2023-04-13 18:36Florian DoldCategorywallet (TS core) => wallet-core