View Issue Details

IDProjectCategoryView StatusLast Update
0007668TalerGeneralpublic2023-04-13 18:26
Reportersebasjm Assigned ToMS Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynoneSeverityfeatureReproducibilityalways
Status closedResolutionwon't fix 
Target Version0.9.3Fixed in Version0.9.2 
Summary0007668: fee rates should be updatable at runtime
DescriptionCurrently accessible at [1]. But I think is more correct if it has it's own endpoint and also some endpoint to update the rates without restarting the service

Also:
1.- I think is ok that conversion rate to be splitted on sell rate and buy rate, but in that case the rate will include the fee. Any reason why not having { rate, sell_fee, buy_fee } or { sell_rate, buy_rate}?. Having both seems redundant.

2.- Creating cashout [2] requires amount_credit which I should not be necessary. It should be calculated by the server given the current fee. Rates in the SPA should be used to render information only.

[1] https://docs.taler.net/libeufin/api-sandbox.html#get--config
[2] https://docs.taler.net/libeufin/api-sandbox.html#post--cashouts
Additional Informationchanging priority after private discussion
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2023-02-10 13:09

developer   ~0019795

"amount_credit" is added in the request so the SPA can confirm that the fee ass correctly calculated

Issue History

Date ModifiedUsernameFieldChange
2023-02-08 20:51sebasjmNew Issue
2023-02-08 20:51sebasjmStatusnew => assigned
2023-02-08 20:51sebasjmAssigned To => MS
2023-02-09 14:02MSPrioritynormal => none
2023-02-09 14:02MSAdditional Information Updated
2023-02-10 13:09sebasjmNote Added: 0019795
2023-02-10 13:10sebasjmStatusassigned => informing
2023-02-10 13:10sebasjmResolutionopen => won't fix
2023-02-21 15:37Christian GrothoffFixed in Version => 0.9.2
2023-02-21 15:38Christian GrothoffStatusinforming => closed
2023-02-22 11:18Christian GrothoffTarget VersionGit master => 0.9.3
2023-04-13 18:26Florian DoldCategorysandbox => libeufin sandbox
2023-04-13 18:26Florian DoldProjectlibeufin => Taler
2023-04-13 18:26Florian DoldCategorylibeufin sandbox => General