View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007631 | GNUnet | secret sharing service | public | 2023-01-29 21:33 | 2023-06-01 18:26 |
| Reporter | ulfvonbelow | Assigned To | Florian Dold | Due Date | |
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.19.4 | Fixed in Version | 0.19.4 | ||
| Summary | 0007631: Memory leak in secretsharing test | ||||
| Description | My understanding is that it's the callback's responsibility to manage the lifetime of the passed share, but in secret_ready_cb in src/secretsharing/test_secretsharing_api.c it just lets it leak. | ||||
| Steps To Reproduce | ./configure --enable-sanitizer make make install make check | ||||
| Additional Information | Patch attached. | ||||
| Tags | memory-leak, patch | ||||
| Attached Files | 0001-SECRETSHARING-don-t-leak-my_share-in-test.patch (858 bytes)
From 6bbaeffb7079a2503dcf42ee5f8c7ca391b6c4c4 Mon Sep 17 00:00:00 2001
From: ulfvonbelow <strilen@tilde.club>
Date: Sun, 29 Jan 2023 05:57:47 -0600
Subject: [PATCH] -SECRETSHARING: don't leak my_share in test.
---
src/secretsharing/test_secretsharing_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/secretsharing/test_secretsharing_api.c b/src/secretsharing/test_secretsharing_api.c
index 227af1c3e..470bfddf4 100644
--- a/src/secretsharing/test_secretsharing_api.c
+++ b/src/secretsharing/test_secretsharing_api.c
@@ -45,6 +45,7 @@ secret_ready_cb (void *cls,
success = 1;
// FIXME: check that our share is valid, which we can do as there's only
// one peer.
+ GNUNET_SECRETSHARING_share_destroy (my_share);
GNUNET_log (GNUNET_ERROR_TYPE_INFO, "secret ready, shutting down\n");
GNUNET_SCHEDULER_shutdown ();
}
--
2.38.1
| ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-01-29 21:33 | ulfvonbelow | New Issue | |
| 2023-01-29 21:33 | ulfvonbelow | Status | new => assigned |
| 2023-01-29 21:33 | ulfvonbelow | Assigned To | => Florian Dold |
| 2023-01-29 21:33 | ulfvonbelow | Tag Attached: memory-leak | |
| 2023-01-29 21:33 | ulfvonbelow | Tag Attached: patch | |
| 2023-01-29 21:33 | ulfvonbelow | File Added: 0001-SECRETSHARING-don-t-leak-my_share-in-test.patch | |
| 2023-02-06 05:16 | schanzen | Status | assigned => resolved |
| 2023-02-06 05:16 | schanzen | Resolution | open => fixed |
| 2023-02-06 05:16 | schanzen | Fixed in Version | => 0.19.4 |
| 2023-02-06 05:19 | schanzen | Target Version | => 0.19.4 |
| 2023-06-01 18:26 | schanzen | Note Added: 0020236 | |
| 2023-06-01 18:26 | schanzen | Status | resolved => closed |