View Issue Details

IDProjectCategoryView StatusLast Update
0007587Talerlibeufin-bankpublic2023-11-29 00:30
ReporterMS Assigned ToAntoine A Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007587: General pass to potentially switch "200 OK" to "204 No Content".
DescriptionThe Taler Wire Gateway API got already changed here: 0676e25980a8b..

This report contiues: 0007301.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-04-17 09:04

manager   ~0020099

What's the rationale for this? It's clearly not a performance issue, why are we complicating the API with different types of responses (empty list vs. 204) to indicate zero transactions?

Florian Dold

2023-04-23 17:36

manager   ~0020133

Discussed with Christian: The idea is that 204 indicates that there are no new transactions *and the client should go into long-polling*, while we expect 200 only when transactions are present.

While I still think that this is an over-optimization, we should still consistently apply what we've agreed on.

Issue History

Date ModifiedUsernameFieldChange
2023-01-14 09:04MSNew Issue
2023-04-13 18:50Florian DoldProjectlibeufin => Taler
2023-04-14 12:30Florian DoldCategoryother => libeufin (general)
2023-04-17 09:04Florian DoldNote Added: 0020099
2023-04-17 09:04Florian DoldTarget Version => 0.9.3
2023-04-23 17:36Florian DoldNote Added: 0020133
2023-04-23 17:36Florian DoldAssigned To => MS
2023-04-23 17:36Florian DoldStatusnew => assigned
2023-06-30 09:17MSTarget Version0.9.3 => 0.9.4
2023-09-03 16:14Christian GrothoffAssigned ToMS => Antoine A
2023-10-13 21:19Christian GrothoffCategorylibeufin (general) => libeufin-bank
2023-10-13 21:19Christian GrothoffProduct Version => git (master)
2023-11-03 14:15Christian GrothoffTarget Version0.9.4 => 0.10
2023-11-09 04:18Antoine AStatusassigned => informing
2023-11-09 04:18Antoine AResolutionopen => fixed
2023-11-09 11:43Christian GrothoffFixed in Version => 0.9.4
2023-11-09 11:43Christian GrothoffTarget Version0.10 => 0.9.4
2023-11-29 00:28Christian GrothoffTarget Version0.9.4 => 0.9.3
2023-11-29 00:29Christian GrothoffFixed in Version0.9.4 => 0.9.3
2023-11-29 00:30Christian GrothoffStatusinforming => closed