View Issue Details

IDProjectCategoryView StatusLast Update
0007580Talerwallet-corepublic2023-09-23 13:09
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007580: when adding an exchange, the wallet should check the /keys JSON for the canonical base URL
DescriptionOtherwise, we get problems when we do peer-to-peer payments, where the exchange expects a signature over the hash of the exchange base URL.

We should also have some tests for the base URL mismatch.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-02-16 21:18

manager   ~0019852

We should probably *additionally* require that requests where the wallet signs over the exchange base URL also include the URL for verification in the request.

Florian Dold

2023-06-06 15:19

manager   ~0020269

Fixed in 698f3566.

Issue History

Date ModifiedUsernameFieldChange
2023-01-13 01:19Florian DoldNew Issue
2023-01-13 01:19Florian DoldStatusnew => assigned
2023-01-13 01:19Florian DoldAssigned To => Florian Dold
2023-01-13 01:20Florian DoldDescription Updated
2023-01-13 01:20Florian DoldTarget Version => 0.9.2
2023-02-16 21:17Florian DoldTarget Version0.9.2 => 0.9.3
2023-02-16 21:18Florian DoldNote Added: 0019852
2023-04-13 18:36Florian DoldCategorywallet (TS core) => wallet-core
2023-06-06 15:19Florian DoldStatusassigned => informing
2023-06-06 15:19Florian DoldResolutionopen => fixed
2023-06-06 15:19Florian DoldNote Added: 0020269
2023-09-23 13:07Christian GrothoffFixed in Version => 0.9.3
2023-09-23 13:09Christian GrothoffStatusinforming => closed