View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007578 | Taler | wallet-core | public | 2023-01-13 00:45 | 2023-09-23 13:09 |
| Reporter | Florian Dold | Assigned To | avalos | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | low | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007578: rename wallet-core p2p payments requests | ||||
| Description | The current API has some weird asymmetries and is rather confusing. In particular, the preparePeer* requests don't prepare anything! It's not even clear what preparePeerPullPayment is supposed to do. Is it about an initiation? An incoming payment? Why is there an effective and raw amount returned? Very confusing ... We need to properly document all those calls and make sure they have clearer names. | ||||
| Tags | No tags attached. | ||||
| has duplicate | 0007565 | closed | Florian Dold | improve consistency of the wallet's peer payments API |
| The FIXME comments in the wallet API types file suggest new, better names: https://git.taler.net/wallet-core.git/tree/packages/taler-wallet-core/src/wallet-api-types.ts Alternatively, since the wallet API is now growing larger and larger, we could also move to namespaced names (but using the same basic terminology). | |
| The operations now have new names in wallet-core. The old names are still supported, see translateLegacyOperationNames (https://git.taler.net/wallet-core.git/tree/packages/taler-wallet-core/src/wallet.ts#n1504). The Android wallet should switch to the new names, then we can remove the mapping. | |
| Apparently, Torsten already took care of this. Could you please confirm? https://git.taler.net/taler-android.git/tree/wallet/src/main/java/net/taler/wallet/peer/PeerManager.kt | |
| Yes, this is resolved. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-01-13 00:45 | Florian Dold | New Issue | |
| 2023-01-13 00:45 | Florian Dold | Status | new => assigned |
| 2023-01-13 00:45 | Florian Dold | Assigned To | => Florian Dold |
| 2023-01-13 01:30 | Florian Dold | Relationship added | has duplicate 0007565 |
| 2023-01-13 16:02 | Christian Grothoff | Severity | minor => tweak |
| 2023-02-17 01:27 | Florian Dold | Status | assigned => feedback |
| 2023-02-17 01:27 | Florian Dold | Note Added: 0019857 | |
| 2023-02-17 01:55 | Florian Dold | Priority | normal => low |
| 2023-02-17 01:55 | Florian Dold | Summary | clarify / restructure wallet-core p2p payments API => rename wallet-core p2p payments requests |
| 2023-02-17 14:06 | Florian Dold | Target Version | 0.9.2 => 0.9.4 |
| 2023-02-20 00:45 | Florian Dold | Assigned To | Florian Dold => avalos |
| 2023-02-20 00:46 | Florian Dold | Note Added: 0019884 | |
| 2023-02-20 00:46 | Florian Dold | Status | feedback => assigned |
| 2023-02-20 00:47 | Florian Dold | Description Updated | |
| 2023-02-20 00:47 | Florian Dold | Target Version | 0.9.4 => 0.9.3 |
| 2023-02-28 16:10 | avalos | Note Added: 0019909 | |
| 2023-03-05 01:33 | Florian Dold | Status | assigned => informing |
| 2023-03-05 01:33 | Florian Dold | Resolution | open => fixed |
| 2023-03-05 01:33 | Florian Dold | Note Added: 0019920 | |
| 2023-04-13 18:36 | Florian Dold | Category | wallet (TS core) => wallet-core |
| 2023-09-23 13:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 13:09 | Christian Grothoff | Status | informing => closed |