View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007516 | Taler | deployment and operations | public | 2022-12-10 14:36 | 2023-09-23 13:09 |
| Reporter | MS | Assigned To | MS | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | sometimes |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007516: TypeScript test harness fails at preparing the database. | ||||
| Description | The following error happens when running the complete suite (command below), marking the test case as failed. It MAY be needed to run the suite more than once. Ideally, the harness should handle the problem, or at least mark the test as skipped. $ taler-wallet-cli testing run-integrationtests | ||||
| Additional Information | running test test-withdrawal-manual in worker process running test test-withdrawal-manual 2022-12-10T14:17:19.331Z harness.ts INFO running test in directory [ "/tmp/taler-integrationtests-Li7zK6/test-withdrawal-manual" ] FATAL: test failed with exception Error: Command failed: createdb "taler-integrationtest" createdb: error: database creation failed: ERROR: database "taler-integrationtest" already exists at ChildProcess.exithandler (node:child_process:398:12) at ChildProcess.emit (node:events:527:28) at maybeClose (node:internal/child_process:1092:16) at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5) { code: 1, killed: false, signal: null, cmd: 'createdb "taler-integrationtest"', stdout: '', stderr: 'createdb: error: database creation failed: ERROR: database "taler-integrationtest" already exists\n' } 2022-12-10T14:17:24.395Z harness.ts INFO shutting down test test-withdrawal-manual finished in worker | ||||
| Tags | No tags attached. | ||||
| I've added some code to the harness to write the output of "dropdb" and "createdb" to log files. Please try again and look at the logs: /tmp/taler-integrationtests-$ID/$TESTNAME/{dropdb,createdb}-stderr.log This might be a permissions issue on your side. | |
| Yes, the log files reflect your last change. And no, in contrast with this bug report, Florian points out that integration tests should fail even when a part not belonging to Taler isn't reliable. That however isn't already the case for the exchange codebase, that instead skips integration tests when the DB, for example, isn't properly configured. | |
| That's different. If the OS is not configured correctly (dependencies missing, database down), then I think 'skip' is correct. But if say there is a bug in libgnunetutil, then the test should fail. | |
| The TypeScript harness was observed to fail with a database down, so if things stay this way, wallet-core.git and exchange.git handle this scenario inconsistently. | |
| I think it should fail --- with a return code of 77 ;-). | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-12-10 14:36 | MS | New Issue | |
| 2022-12-10 14:36 | MS | Description Updated | |
| 2022-12-10 14:37 | MS | Reproducibility | have not tried => sometimes |
| 2022-12-10 14:37 | MS | Product Version | => git (master) |
| 2022-12-10 14:38 | MS | Assigned To | => Florian Dold |
| 2022-12-10 14:38 | MS | Status | new => assigned |
| 2022-12-10 14:41 | MS | Summary | TypeScript test harness fails itself at preparing the database. => TypeScript test harness fails at preparing the database. |
| 2023-01-10 12:10 | Florian Dold | Assigned To | Florian Dold => MS |
| 2023-01-10 12:10 | Florian Dold | Status | assigned => feedback |
| 2023-01-10 12:10 | Florian Dold | Note Added: 0019623 | |
| 2023-04-04 14:21 | Florian Dold | Target Version | => 0.9.3 |
| 2023-04-18 09:09 | MS | Note Added: 0020105 | |
| 2023-04-18 09:10 | MS | Status | feedback => informing |
| 2023-04-18 09:10 | MS | Resolution | open => fixed |
| 2023-04-18 09:12 | MS | Note Edited: 0020105 | |
| 2023-04-18 13:06 | Christian Grothoff | Note Added: 0020106 | |
| 2023-04-18 14:38 | MS | Note Added: 0020110 | |
| 2023-04-18 14:41 | Christian Grothoff | Note Added: 0020111 | |
| 2023-09-23 13:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 13:09 | Christian Grothoff | Status | informing => closed |