View Issue Details

IDProjectCategoryView StatusLast Update
0007503Talerwallet-corepublic2023-02-21 15:39
Reportersebasjm Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityminorReproducibilityhave not tried
Status closedResolutionno change required 
Target Version0.9.2Fixed in Version0.9.2 
Summary0007503: remove NotificationType.WaitingForRetry notification
DescriptionThe notification just let the client now that a interaction has occurred wich is not meaningful.

I think NotificationType.PendingOperationProcessed should be enough if what we want is to show progress
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2023-02-17 11:42

manager   ~0019862

I don't think we should remove it. It doesn't let the client know that some interaction has occurred, it lets the client know that (1) the wallet's retry loop is still active and (2) how much work the wallet still has to do in general.

It's also important in tests. The new variant of integration tests relies purely on notifications, and the WaitingForRetry notification lets us know whether the wallet is "done" and we can inspect the state to see if the tests succeeded.

Issue History

Date ModifiedUsernameFieldChange
2022-11-30 14:04sebasjmNew Issue
2022-11-30 14:04sebasjmStatusnew => assigned
2022-11-30 14:04sebasjmAssigned To => Florian Dold
2023-02-17 01:53Florian DoldPrioritynormal => low
2023-02-17 11:42Florian DoldStatusassigned => informing
2023-02-17 11:42Florian DoldResolutionopen => no change required
2023-02-17 11:42Florian DoldNote Added: 0019862
2023-02-21 15:39Christian GrothoffFixed in Version => 0.9.2
2023-02-21 15:39Christian GrothoffTarget Version => 0.9.2
2023-02-21 15:39Christian GrothoffStatusinforming => closed
2023-04-13 18:36Florian DoldCategorywallet (TS core) => wallet-core