View Issue Details

IDProjectCategoryView StatusLast Update
0007499Talermerchant backendpublic2023-01-26 21:53
ReporterMS Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version0.9.1Fixed in Version0.9.1 
Summary0007499: "secret-token:" prefix dual behavior
DescriptionThe merchant backend tolerates a missing RFC 8959 prefix when that's
passed as a configuration value (only observed via the "-a" CLI option), to
the point that it silently adds one if that's not found, but then refuses HTTP
requests that lack such a prefix.

That has two problems: (1) the policy is inconsistent, and (2) it nullifies the
main reason to have such a RFC: easier identification of tokens through published
text.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2022-11-29 09:52

manager   ~0019490

You are right, we should not auto-add the prefix and instead force the user to supply it.

Christian Grothoff

2022-11-29 20:55

manager   ~0019491

Fixed in ad99fc41..361833d6

Issue History

Date ModifiedUsernameFieldChange
2022-11-29 09:18MSNew Issue
2022-11-29 09:18MSStatusnew => assigned
2022-11-29 09:18MSAssigned To => Christian Grothoff
2022-11-29 09:52Christian GrothoffNote Added: 0019490
2022-11-29 20:55Christian GrothoffStatusassigned => informing
2022-11-29 20:55Christian GrothoffResolutionopen => fixed
2022-11-29 20:55Christian GrothoffFixed in Version => 0.9.1
2022-11-29 20:55Christian GrothoffNote Added: 0019491
2023-01-23 21:25Christian GrothoffTarget Version => 0.9.1
2023-01-26 21:53Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend