View Issue Details

IDProjectCategoryView StatusLast Update
0007477Talerwallet (Android App)public2023-01-26 21:53
Reportersebasjm Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.1Fixed in Version0.9.1 
Summary0007477: deposit tx should show information about when the wire transfer is going to be made
DescriptionRight now the deposit timestamp is being shown, but the user doesn't have information about when the money is going to be effectively sent.

seen on android.

Also check on WebEx
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

grote

2022-11-17 17:47

reporter   ~0019436

Could you please add more info here? Where is the info about "when the wire transfer is going to be made"?

sebasjm

2022-11-17 19:13

developer   ~0019439

Wire transfer deadline should be added in wallet-core first. I have checked and is not there yet.

This will help the user understand that the deposit will take some time before is being display by the bank
https://docs.taler.net/core/api-exchange.html#deposit

sebasjm

2022-11-18 16:52

developer   ~0019447

wireTransferDeadline added in the deposit tx so this is posible to render in WebEx

wire transfer is not being made by the exchange to my bank account, tho, should I open another issue? (demo and local env)

Christian Grothoff

2022-11-18 18:19

manager   ~0019449

Do you run the taler-exchange-aggregator and taler-exchange-transfer helpers? Does taler-exchange-transfer have the correct bank credentials?

sebasjm

2022-12-22 15:57

developer   ~0019536

Yes, testing in demo now. Seems to be properly configured but the wire transfer is taking too long, not honoring the wire transfer deadline from the contract term.

wid XXRM58FH1V18YK7NRXH46BK2SE1XQRX4X34286BF8T2A99S72ZCG

Bank does not show the transfer timestamp (just date) but it took like 2 hours.

{
    "contractTermsHash": "FDD4KHS8K6W3ME7JWB8DSWHPDMXS7MK03SHG9XV88Y17ANWS01MEXQZ3TDKK5XN8KXP1G3GPJ3K50M85QJEQG21YM1V4KWDJA8ZXWN8",
    "contractTermsRaw": {
        "auditors": [],
        "exchanges": [
            {
                "master_pub": "6J0RZTJC6AV21WXK87BTE67WTHE9P2QSHF2BZXTP7PDZY2ARYBPG",
                "url": "https://exchange.demo.taler.net/"
            }
        ],
        "amount": "KUDOS:1",
        "max_fee": "KUDOS:1",
        "max_wire_fee": "KUDOS:1",
        "wire_method": "iban",
        "timestamp": {
            "t_s": 1671716230
        },
        "merchant_base_url": "",
        "summary": "",
        "nonce": "EHYYJ0YNGDH9SCYEDRXESVX8502HMQ8S1VMYEDX52A6B8K37P0M0",
        "wire_transfer_deadline": {
            "t_s": 1671716230
        },
        "order_id": "",
        "h_wire": "RT3JJS6JKFP1ZDKK8WP7R9M2CGR4NFQQHRM6N2P6RXEQP1J3B3J8V048VCP2CTXM67M08FQ1SH45F01SHASXJNSE8KP653X6FZZ3Y4G",
        "pay_deadline": {
            "t_s": 1671719830
        },
        "merchant": {
            "name": "(wallet)"
        },
        "merchant_pub": "Z8S8GDMN3BKKB2MSA4VHZX0CRFWX3WZGK7PXGJJ011SDN31BR7X0",
        "refund_deadline": {
            "t_s": 0
        }
    },
 ............. removed .............
    "totalPayCost": "KUDOS:1.1",
    "effectiveDepositAmount": "KUDOS:0.98",
    "wire": {
        "payto_uri": "payto://iban/DE118695?receiver-name=qwe",
        "salt": "G387MYS1YKDBN8RN27W1JM7BD4"
    },
    "operationStatus": 50
}
Selection_342.png (75,505 bytes)   
Selection_342.png (75,505 bytes)   
Selection_341.png (31,924 bytes)   
Selection_341.png (31,924 bytes)   

Christian Grothoff

2022-12-27 00:07

manager   ~0019541

So you are now saying the transfer did happen, just "too late"? Could it be a timezone issue?

sebasjm

2022-12-27 22:08

developer   ~0019542

> So you are now saying the transfer did happen, just "too late"?
Yes

> Could it be a timezone issue?
I don't see how. Contract terms has a timestamp and wallet expect at 1671716230

$ date -d @1671716230 "+%D %T %Z"
12/22/22 10:37:10 -03
$ TZ="CET" date -d @1671716230 "+%D %T %Z"
12/22/22 14:37:10 CET

which is also the moment when the deposit is made. So I expect to see the deposit after some seconds.

@ms maybe a timestamp with millisecond precision will help. (endpoint /demobanks/default/access-api/accounts/<account>/transactions )

I have also saw that one deposit was splitted and the sum of them didn't add up to what the wallet ask for:

1.- wallet screen attach (deposit instruction)
2.- bank transaction response: 2 transactions for 0.08 KUDOS and 1.79 KUDOS witch add up to 1.87 KUDOS !== 1.88 KUDOS (after fees)
3.- contract terms:

{
    "contractTermsHash": "DR17KV9Z83PWYXNZCC92AWCT1WHAPMFA11F6D74QPG6X3PC8WXXNEPHC4BCRFZA6KBFEFXFQY6X4YVNM1YBNWDKHQK21Q4R3MHRDG6R",
    "contractTermsRaw": {
        "auditors": [],
        "exchanges": [
            {
                "master_pub": "6J0RZTJC6AV21WXK87BTE67WTHE9P2QSHF2BZXTP7PDZY2ARYBPG",
                "url": "https://exchange.demo.taler.net/"
            }
        ],
        "amount": "KUDOS:2",
        "max_fee": "KUDOS:2",
        "max_wire_fee": "KUDOS:2",
        "wire_method": "iban",
        "timestamp": {
            "t_s": 1672151819
        },
        "merchant_base_url": "",
        "summary": "",
        "nonce": "YBY3EGBZ41Q398Q8H75N71J7NCJM3M4H0RZ62PAR2CQXDP5BH5F0",
        "wire_transfer_deadline": {
            "t_s": 1672151819
        },
        "order_id": "",
        "h_wire": "6SZAV88V1537SKDCAZDKSN9Y47CS9A70RVJSS587D8TTC5MQZSXHAJKA431C7C2J3K2B8FXTWN6E96TWC575NFW5THJ4TATCXE3D10R",
        "pay_deadline": {
            "t_s": 1672155419
        },
        "merchant": {
            "name": "(wallet)"
        },
        "merchant_pub": "SHP2S6NSTP1RDV0G3EWQD1SWM2BBR83QW6FC6GBPBK6DX1EFSV6G",
        "refund_deadline": {
            "t_s": 0
        }
    },
    "depositGroupId": "TMFZTH2B7H2K6JBDKDPTSC35RTNHXKGQDHQNHN71MF70VDV943VG",
    "noncePriv": "CWQRR0RPKSQHYYA163FDK08JVD86K52K1KT5AJAK6NKQZ08C654G",
    "noncePub": "YBY3EGBZ41Q398Q8H75N71J7NCJM3M4H0RZ62PAR2CQXDP5BH5F0",
    "timestampCreated": {
        "t_s": 1672151819
    },
    "timestampFinished": {
        "t_s": 1672151827
    },
    "payCoinSelection": {
        "paymentAmount": "KUDOS:2",
        "coinContributions": [
            "KUDOS:1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1",
            "KUDOS:0.1"
        ],
        "coinPubs": [
            "GYT0GQ1SJ1GZY7N7N9BF8TFJ8EXRV1YFKT3NJQ7EBFWN8DRAJ8ZG",
            "1MFKTZ9SK75YCKJB1ZF6N5R0P33J6ME49T7PHYD9GE7NP35TJHQG",
            "3VBG5TCVE94804YHRBKJX87Y8P8Y505JWM7GGEGR4T3N21X73TNG",
            "4BE0DCA1FQASZ0MH6QV5XD558A13SJ4RVQ63W0PGN3QC4VSHA440",
            "7JFAGSY3K12XBHHJQ2G150627KRGF25CW21K41SP8MHMCYR857TG",
            "7RT8CRA3BHF3XC6YXVVFKNCA7XBEAY6A88TBSZF13KVN393DHDT0",
            "860B2JYA2FH88CV4RDEZ7MEHD66XTTJJ66CREJG2XKN96B6HNT20",
            "9PQ1BTA6HQV0SZ0HD323Q5RBA6XX62N86VM512CFB8NX7A1T72HG",
            "AJND4BHEA84NZ2YQEWBZKJS6243H37AGKP48FQBBX88J3JXV9DP0",
            "AXZAR77D0KKF08WQXV4JMW66J9YZTPJKZQ8T3PEWACZ921XHFP0G",
            "B312504BYJ5R8DPKTGYCHHJDM3V47ZKSN57J068BD5CSW7RKAFDG"
        ],
        "customerDepositFees": "KUDOS:0",
        "customerWireFees": "KUDOS:0"
    },
    "payCoinSelectionUid": "8KGQWD4MQ37P8SXC4HJ53TYYJGMGK0CP7K25XYB0V569J9RZ9KBG",
    "depositedPerCoin": [
        true,
        true,
        true,
        true,
        true,
        true,
        true,
        true,
        true,
        true,
        true
    ],
    "merchantPriv": "MVX292TCF29THQYR66SAE85HW2VRY133022P42DHFR2DDG8GPQ1G",
    "merchantPub": "SHP2S6NSTP1RDV0G3EWQD1SWM2BBR83QW6FC6GBPBK6DX1EFSV6G",
    "totalPayCost": "KUDOS:2",
    "effectiveDepositAmount": "KUDOS:1.88",
    "wire": {
        "payto_uri": "payto://iban/DE118695?receiver-name=asd",
        "salt": "KJYX4ECSDN1Q0ZB4AT2WXFE3A8"
    },
    "operationStatus": 50
}
Selection_347.png (32,521 bytes)   
Selection_347.png (32,521 bytes)   

Christian Grothoff

2023-01-10 17:45

manager   ~0019626

https://docs.taler.net/core/api-exchange.html#get--deposits-$H_WIRE-$MERCHANT_PUB-$H_CONTRACT_TERMS-$COIN_PUB
is the exchange API to request the current deposit status.

Christian Grothoff

2023-01-10 17:47

manager   ~0019627

Last edited: 2023-01-10 17:47

Florian says to use track deposit group as a wallet-core API.

sebasjm

2023-01-15 21:27

developer   ~0019672

fixed bd57fa46a

Issue History

Date ModifiedUsernameFieldChange
2022-11-17 17:36sebasjmNew Issue
2022-11-17 17:36sebasjmStatusnew => assigned
2022-11-17 17:36sebasjmAssigned To => grote
2022-11-17 17:47groteNote Added: 0019436
2022-11-17 19:10sebasjmAssigned Togrote => sebasjm
2022-11-17 19:13sebasjmNote Added: 0019439
2022-11-18 16:52sebasjmNote Added: 0019447
2022-11-18 16:52sebasjmAssigned Tosebasjm => Christian Grothoff
2022-11-18 16:52sebasjmStatusassigned => feedback
2022-11-18 18:19Christian GrothoffNote Added: 0019449
2022-11-18 18:31Christian GrothoffAssigned ToChristian Grothoff => sebasjm
2022-12-22 15:57sebasjmNote Added: 0019536
2022-12-22 15:57sebasjmFile Added: Selection_342.png
2022-12-22 15:57sebasjmFile Added: Selection_341.png
2022-12-22 15:58sebasjmAssigned Tosebasjm => Christian Grothoff
2022-12-27 00:07Christian GrothoffNote Added: 0019541
2022-12-27 22:08sebasjmNote Added: 0019542
2022-12-27 22:08sebasjmFile Added: Selection_347.png
2022-12-27 22:08sebasjmStatusfeedback => assigned
2023-01-10 17:45Christian GrothoffNote Added: 0019626
2023-01-10 17:47Christian GrothoffNote Added: 0019627
2023-01-10 17:47Christian GrothoffNote Edited: 0019627
2023-01-10 17:47Christian GrothoffAssigned ToChristian Grothoff => sebasjm
2023-01-15 21:27sebasjmStatusassigned => informing
2023-01-15 21:27sebasjmResolutionopen => fixed
2023-01-15 21:27sebasjmNote Added: 0019672
2023-01-23 21:25Christian GrothoffFixed in Version => 0.9.1
2023-01-26 21:53Christian GrothoffStatusinforming => closed