View Issue Details

IDProjectCategoryView StatusLast Update
0007468Talerwallet (Android App)public2023-02-21 15:39
Reportersebasjm Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9.2Fixed in Version0.9.2 
Summary0007468: rename "waiting for confirmation" => "need approval in the bank webapp"
DescriptionAfter withdrawal started from the wallet the transaction says:

 " waiting for confirmation "

This may be confusing since user may think that the backend is doing something.

Rename to "need approval in the bank webapp"

> Plus context switch back to bank via URL as discussed here earlier.

This was seen in Android but check webex for the same behavior.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2022-11-18 16:02

developer   ~0019444

This is what I would like to do in the WebEx, the transaction is already pending.

The problems is that wallet doesn't have the "exchangeReceivedWireTransfer" information. Is it posible?

switch (tx.withdrawalDetails.type)

 case WithdrawalType.TalerBankIntegrationApi

  if not tx.withdrawalDetails.confirmed
       return Need approval in the Bank
  else if not tx.withdrawalDetails,exchangeReceivedWireTransfer
     return Exchange is waiting the wire transfer
  else
    return Coins are in the way

  case WithdrawalType.ManualTransfer
     if not tx.withdrawalDetails,exchangeReceivedWireTransfer
       return Exchange is waiting the wire transfer
      else
        return Coins are in the way


cc @Christian

Christian Grothoff

2023-01-06 14:03

manager   ~0019595

The wallet can certainly query the reserve status to see if money has arrived. => Florian.

Florian Dold

2023-02-13 12:17

manager   ~0019812

In wallet-core.git 22cb8adaa6d9584ad7638b9019 I've added an additional withdrawalDetails.reserveIsReady field to the withdrawal transaction.

I've also modified the test-withdrawal-bank-integrated.ts integration test to clarify and test the transaction lifecycle.

sebasjm

2023-02-13 12:28

developer   ~0019813

fix at bb6644367

Issue History

Date ModifiedUsernameFieldChange
2022-11-17 17:05sebasjmNew Issue
2022-11-17 17:05sebasjmStatusnew => assigned
2022-11-17 17:05sebasjmAssigned To => grote
2022-11-18 16:02sebasjmNote Added: 0019444
2022-12-20 17:26Christian GrothoffTarget Version0.9.1 => 0.9.2
2023-01-03 14:40groteAssigned Togrote => Christian Grothoff
2023-01-03 14:40groteStatusassigned => feedback
2023-01-06 14:03Christian GrothoffNote Added: 0019595
2023-01-06 14:03Christian GrothoffAssigned ToChristian Grothoff => Florian Dold
2023-02-13 12:16Florian DoldAssigned ToFlorian Dold => sebasjm
2023-02-13 12:17Florian DoldNote Added: 0019812
2023-02-13 12:17Florian DoldStatusfeedback => assigned
2023-02-13 12:28sebasjmNote Added: 0019813
2023-02-14 14:02sebasjmStatusassigned => informing
2023-02-14 14:02sebasjmResolutionopen => fixed
2023-02-21 15:39Christian GrothoffFixed in Version => 0.9.2
2023-02-21 15:39Christian GrothoffStatusinforming => closed