View Issue Details

IDProjectCategoryView StatusLast Update
0007442Talerwallet (WebExtension)public2023-01-26 21:53
ReporterChristian Grothoff Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytrivialReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.9 
Target Version0.9.1Fixed in Version0.9.1 
Summary0007442: ugly dialog to add account for sending money back via IBAN
DescriptionThe dialog to add a bank account is quite ugly (see attached screenshot, if in doubt). I also believe it violates the accessibility rules: the fonts are just way too small, even at a huge zoom level. We should:

0) Make the labels before the three entry lines MUCH bigger.
1) Validate the IBAN (do we?). The checksuming algo can be found in libtalerutil IIRC.
2) I'd change "Account name" to "Receiver name", that's what we call it in RFC 8905 and might be clearer.
    We could even write "Receiver name (of the target bank account owner)".
3) Account alias is also not super clear. You have a "*" behind it, but that doesn't give me any more details either.
    Maybe write more explicitly: "Alias to remember this account by in the future (optional)", seems we have the space.

I'm not sure the "We can not validate the account" hint is useful, pretty obvious, for anyone who has ever done any banking, is it not?
TagsNo tags attached.
Attached Files
ugly-dialog.png (21,073 bytes)   
ugly-dialog.png (21,073 bytes)   

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2022-11-07 22:31

developer   ~0019389

material design support was broken, fixed on.

label start inside the field area
on focus it moves outside and the placeholder is shown
placeholder is removed when the user starts typing
error message is better also

https://m2.material.io/go/design-text-fields/

sebasjm

2022-11-07 22:31

developer   ~0019390

fixed at 43c7cff75055f72c7d59a7180ae8da2554456d8d

Issue History

Date ModifiedUsernameFieldChange
2022-11-06 22:09Christian GrothoffNew Issue
2022-11-06 22:09Christian GrothoffStatusnew => assigned
2022-11-06 22:09Christian GrothoffAssigned To => sebasjm
2022-11-06 22:09Christian GrothoffFile Added: ugly-dialog.png
2022-11-07 22:31sebasjmNote Added: 0019389
2022-11-07 22:31sebasjmStatusassigned => informing
2022-11-07 22:31sebasjmResolutionopen => fixed
2022-11-07 22:31sebasjmNote Added: 0019390
2022-11-18 21:42Christian GrothoffFixed in Version => 0.9.1
2023-01-26 21:53Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)