View Issue Details

IDProjectCategoryView StatusLast Update
0007440Talerwallet (WebExtension)public2023-09-23 13:09
ReporterChristian Grothoff Assigned ToMarcS Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionreopened 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.9 
Target Version0.9.3Fixed in Version0.9.3 
Summary0007440: cannot specify expiration for push payments in WebExtension
DescriptionWhen sending money to another wallet, it must be possible for the user to specify an expiration time for the push payment, as only then the coins that were pushed can be recovered if the receiver didn't accept the payment.

Similarly, we should also allow setting an expiration date when invoicing (technically a separate issue, but very symmetric so should be done at the same time).

This is also missing in the other wallets.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0007439 closedavalos cannot specify expiration for push payments in Android wallet 

Activities

sebasjm

2022-11-08 02:30

developer   ~0019391

first, it should be implemented by wallet-core :)

* parse the PeerContractTerms
* use amount from CT (instead of the request)
* use expiration from the CT (instead of hardcoded)
* both push and pull request

cc @grote @marc

grote

2022-11-08 14:00

reporter   ~0019392

can you please get me an API diff together with the wallet-core version this first lands in, once done, please?
additional info on how the current API flow must be adapted will be appreciated.

sebasjm

2022-11-08 15:34

developer   ~0019397

@grote yes, AFAIK this is covered by the documentation generation that @florian mentioned

FTR this will also apply to pull payments

sebasjm

2022-11-10 13:13

developer   ~0019398

at 5c742afb

MarcS

2023-05-20 15:12

developer   ~0020197

re-opened for iOS

MarcS

2023-07-08 11:05

developer   ~0020344

Implemented in iOS 0.9.3.
Currently only as three buttons with 1 Day, 7 Days, 30 Days. User must choose one of them...

Issue History

Date ModifiedUsernameFieldChange
2022-11-06 21:55Christian GrothoffNew Issue
2022-11-06 21:55Christian GrothoffStatusnew => assigned
2022-11-06 21:55Christian GrothoffAssigned To => sebasjm
2022-11-06 21:56Christian GrothoffRelationship addedrelated to 0007439
2022-11-08 02:30sebasjmNote Added: 0019391
2022-11-08 14:00groteNote Added: 0019392
2022-11-08 15:34sebasjmNote Added: 0019397
2022-11-10 13:13sebasjmStatusassigned => informing
2022-11-10 13:13sebasjmResolutionopen => fixed
2022-11-10 13:13sebasjmNote Added: 0019398
2022-11-18 21:42Christian GrothoffFixed in Version => 0.9.1
2023-01-26 21:53Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)
2023-05-20 15:12MarcSAssigned Tosebasjm => MarcS
2023-05-20 15:12MarcSStatusclosed => feedback
2023-05-20 15:12MarcSResolutionfixed => reopened
2023-05-20 15:12MarcSNote Added: 0020197
2023-07-08 11:05MarcSNote Added: 0020344
2023-09-05 10:37Florian DoldTarget Version0.9.1 => 0.9.3
2023-09-23 13:03Christian GrothoffStatusfeedback => informing
2023-09-23 13:03Christian GrothoffFixed in Version0.9.1 => 0.9.3
2023-09-23 13:09Christian GrothoffStatusinforming => closed