View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007406 | Taler | wallet (Android App) | public | 2022-10-22 16:21 | 2022-11-04 19:52 |
| Reporter | Christian Grothoff | Assigned To | grote | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.9 | ||||
| Summary | 0007406: wallet-initiated withdraw does not work | ||||
| Description | When I try to withdraw kudos starting with the Android wallet on "receive funds" and then 'withdraw from bank account", I get a message "Subject: Error: no subject in URI" instead of a proper wire transfer subject. The same operation does work in the WebExtension wallet. | ||||
| Tags | No tags attached. | ||||
| Also, those dialogs lack the 'age restriction' chooser, which again exists in WebExtension (naturally, should only be shown if the exchange supports age restrictions). | |
| > I get a message "Subject: Error: no subject in URI" instead of a proper wire transfer subject. The subject kept changing and when asking for where the subject is supposed to be I didn't get a response. It used to be in ?subject=foo where is it now? Btw. if we keep changing stuff like this without any communication, all wallets will break and we need to find such issues and run after a fix in each wallet which is far from ideal. > Also, those dialogs lack the 'age restriction' chooser, which again exists in WebExtension (naturally, should only be shown if the exchange supports age restrictions). age restrictions are not implemented in the android wallet. this is tracked in https://bugs.gnunet.org/view.php?id=7352 | |
| I don't know if/when it ever was 'subject': RFC 8905 says it should be 'message'. Anyway, from what I see, the wallet core also seems to have an explicit field 'reserve pub', which is probably better than extracting the reserve pub from the payto://URI as there it may be mixed with some human-readable text. Ultimately, the person to ask about the API is Florian. Florian, can you answer how to best get the reserve public key? | |
| Changing subject to message seems to work: https://git.taler.net/taler-android.git/commit/?id=28814bc6cc7df29cb425dd867042e7f23921b9a8 | |
| The response to acceptManualWithdrawal contains a "reservePub" field, which should be used to construct the final payto URI to hand to the user. The client (i.e. UI) needs to manually set the "message" query parameter of the payto URI. Do you think it would be better if wallet-core already provided this? I've left it out for i18n concerns so far, but I think we can't avoid also i18n-izing wallet-core in the end anyway ... | |
| Currently, I am using the first Uri in WithdrawalDetailsForManualTransfer.exchangePaytoUris and extract the "message" parameter there. Is this still the right way, or do I need to use reservePub as message myself? | |
| Ah. If the payto URIs now already include the "message" parameter, then everything is fine and you can use them. | |
| Resolved in https://git.taler.net/taler-android.git/commit/?id=28814bc6cc7df29cb425dd867042e7f23921b9a8 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-10-22 16:21 | Christian Grothoff | New Issue | |
| 2022-10-22 16:21 | Christian Grothoff | Status | new => assigned |
| 2022-10-22 16:21 | Christian Grothoff | Assigned To | => grote |
| 2022-10-22 16:22 | Christian Grothoff | Note Added: 0019271 | |
| 2022-10-24 18:04 | grote | Note Added: 0019292 | |
| 2022-10-24 18:30 | Christian Grothoff | Note Added: 0019295 | |
| 2022-10-24 18:31 | Christian Grothoff | Assigned To | grote => Florian Dold |
| 2022-10-24 18:31 | Christian Grothoff | Status | assigned => feedback |
| 2022-10-24 19:55 | grote | Note Added: 0019303 | |
| 2022-11-01 13:01 | Florian Dold | Note Added: 0019324 | |
| 2022-11-01 13:01 | Florian Dold | Assigned To | Florian Dold => grote |
| 2022-11-01 17:36 | grote | Note Added: 0019338 | |
| 2022-11-01 17:39 | Florian Dold | Note Added: 0019339 | |
| 2022-11-01 18:10 | grote | Status | feedback => informing |
| 2022-11-01 18:10 | grote | Resolution | open => fixed |
| 2022-11-01 18:10 | grote | Note Added: 0019340 | |
| 2022-11-04 19:52 | Christian Grothoff | Status | informing => closed |