View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007397 | GNUnet | namestore service | public | 2022-10-18 11:46 | 2022-10-31 02:22 |
| Reporter | schanzen | Assigned To | Christian Grothoff | Due Date | |
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.18.0 | Fixed in Version | 0.18.0 | ||
| Summary | 0007397: Improve expiration time in namestore record JSON | ||||
| Description | We should use the same data type that GNUNET_JSON_ creates for absolute/releative time, instead of having an ill-defined human-readable time here. Furthermore, I'm not sure it is ideal to have the "relative_expiration" that separated. I propose: expiration { is_relative : true; relative_expiration : RelativeTime; } or expiration { is_relative : false; absolute_expiration : AbsoluteTime; } which is the format that is also easiest to parse in TypeScript (using 'is_relative' as the type discriminator). | ||||
| Tags | No tags attached. | ||||
| The proposed format it really annoying to parse using our parser as it does not allow for optional fields. So there is a condition now (is_relative) that determines the format, but we have to parse first to know the format. Which is really strange. I suggest we keep 1 number field that is named "expiration_time" and its contents are determined by is_relative. Just like it is now. | |
| Nvm I was thinking of how this needs to be parsed in Go 9c7255313..6d56e7dc6 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-10-18 11:46 | schanzen | New Issue | |
| 2022-10-19 07:27 | schanzen | Assigned To | => schanzen |
| 2022-10-19 07:27 | schanzen | Status | new => assigned |
| 2022-10-21 13:00 | schanzen | Note Added: 0019263 | |
| 2022-10-21 13:26 | schanzen | Status | assigned => feedback |
| 2022-10-21 13:28 | schanzen | Assigned To | schanzen => Christian Grothoff |
| 2022-10-23 13:38 | schanzen | Status | feedback => resolved |
| 2022-10-23 13:38 | schanzen | Resolution | open => fixed |
| 2022-10-23 13:38 | schanzen | Fixed in Version | => 0.18.0 |
| 2022-10-23 13:38 | schanzen | Note Added: 0019277 | |
| 2022-10-31 02:22 | schanzen | Status | resolved => closed |