View Issue Details

IDProjectCategoryView StatusLast Update
0007390Talerwallet-corepublic2022-11-04 19:52
ReporterttnAssigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9Fixed in Version0.9 
Summary0007390: CS 4.1.1 (LEVEL A) -- Parsing
DescriptionIn content implemented using markup languages, elements have complete start
and end tags, elements are nested according to their specifications, elements do
not contain duplicate attributes, and any IDs are unique, except where the
specifications allow these features.

The following page has an HTML attribute and element that don't
have ending or starting tags that comply with the HTML
specifications:
https://shop.demo.taler.net/en/ (See the extra quote in the
attribute name at line 203, column 114 and the

end tag
while there is no open

element From line 1941, column 133;
to line 1941, column 136.)

TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2022-10-10 20:22

manager   ~0019214

I think I've fixed the specific parse errors, but we should double-check once the demo has been updated AND probably re-check "all" pages.

sebasjm

2022-10-19 04:31

developer   ~0019236

I'm using https://validator.w3.org/ to check

The blog has a problem with some articles, in particular with "Only the Free World Can Stand Up to Microsoft" but it may happen with others:

The python script read the html article and tries to get the subtitle from a paragraph.
The first paragraph in this article has an email address and the text has a "greater than" email "lesser than" which is pasted verbatim and sent to the browser with an email as an invalid html tag.

Christian Grothoff

2022-10-19 06:28

manager   ~0019244

I've modified the content.py extraction logic to go for the first li or p element in the body, which should get the proper teaser for the free-world-microsoft article. Furthermore, I've changed the code to use '.prettify()', which should mean it now outputs HTML instead of text with <>. Not yet tested, got to run ;-).

Christian Grothoff

2022-10-20 22:21

manager   ~0019262

Parses fine now.

Issue History

Date ModifiedUsernameFieldChange
2022-10-10 19:55ttnNew Issue
2022-10-10 19:55ttnStatusnew => assigned
2022-10-10 19:55ttnAssigned To => sebasjm
2022-10-10 20:22Christian GrothoffNote Added: 0019214
2022-10-19 04:31sebasjmNote Added: 0019236
2022-10-19 06:04sebasjmAssigned Tosebasjm => Christian Grothoff
2022-10-19 06:28Christian GrothoffNote Added: 0019244
2022-10-20 09:39Christian GrothoffTarget Versiongit (master) => 0.9
2022-10-20 22:21Christian GrothoffStatusassigned => informing
2022-10-20 22:21Christian GrothoffResolutionopen => fixed
2022-10-20 22:21Christian GrothoffFixed in Version => 0.9
2022-10-20 22:21Christian GrothoffNote Added: 0019262
2022-11-04 19:52Christian GrothoffStatusinforming => closed
2023-04-13 18:36Florian DoldCategorywallet (TS core) => wallet-core