View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007333 | Taler | wallet-core | public | 2022-09-07 19:46 | 2023-09-23 13:09 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0007333: introduce minimalistic JS API for wallet that can be used by SPAs | ||||
| Description | With an approach similar to MetaMask, we can provide a simple talerWallet.handleUri API into the browser that can be used by SPAs to handle URIs without a navigation. Additionally, the wallet is currently over-eager to open taler:// URIs. We should remove this behavior once the SPA API is available. Otherwise, *every* taler://... link on any page would trigger the wallet. | ||||
| Tags | No tags attached. | ||||
| webex now injects a script that add the taler support API this is an example of can be done programmatically window.location = window.taler.api.convertURIToWebExtensionPath("taler://pay/asd") it should not be needed, since after the script run every link with href.value that start with taler should be intercepted also, the scripts observes DOM mutation for new links that appears after initial load (like in the spa) | |
| I have intentionally commented out this 2 lines https://git.taler.net/wallet-core.git/tree/packages/taler-wallet-webextension/src/taler-wallet-interaction-support.ts#n50 https://git.taler.net/wallet-core.git/tree/packages/taler-wallet-webextension/src/taler-wallet-interaction-loader.ts#n55 that check the presences of the taler support meta tag, this allows testing without updating bank.demo.taler.net and the merchant payments pages. This should be un-commented after merchant and bank is updated | |
| feedback was given, final issues addressed. commit b34f3568e8c9dde73f11583a6b46ef1509990397 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-09-07 19:46 | Florian Dold | New Issue | |
| 2022-09-07 19:46 | Florian Dold | Status | new => assigned |
| 2022-09-07 19:46 | Florian Dold | Assigned To | => Florian Dold |
| 2023-01-04 12:37 | Florian Dold | Summary | introduce minimlistic JS API for wallet that can be used by SPAs => introduce minimalistic JS API for wallet that can be used by SPAs |
| 2023-02-02 17:44 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2023-02-02 17:44 | Florian Dold | Assigned To | sebasjm => Florian Dold |
| 2023-02-02 17:44 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2023-02-19 22:32 | Florian Dold | Target Version | => 0.9.3 |
| 2023-04-13 16:19 | sebasjm | Note Added: 0020087 | |
| 2023-04-13 16:20 | sebasjm | Assigned To | sebasjm => Florian Dold |
| 2023-04-13 16:20 | sebasjm | Status | assigned => feedback |
| 2023-04-13 16:23 | sebasjm | Note Added: 0020088 | |
| 2023-04-13 18:36 | Florian Dold | Category | wallet (TS core) => wallet-core |
| 2023-04-18 13:52 | sebasjm | Status | feedback => informing |
| 2023-04-18 13:52 | sebasjm | Resolution | open => fixed |
| 2023-04-18 13:52 | sebasjm | Note Added: 0020109 | |
| 2023-09-23 13:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 13:09 | Christian Grothoff | Status | informing => closed |