View Issue Details

IDProjectCategoryView StatusLast Update
0007328Talerwallet (WebExtension)public2022-11-04 19:52
ReporterFlorian Dold Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionfixed 
Target Version0.9Fixed in Version0.9 
Summary0007328: webextension ships with huge, unnecessary sources and sourcemaps
DescriptionThe "dist" folder of the web extension is currently 55MB (!!!) big.

It AFAICT contains source files that are completely unnecessary for the webextension.

E.g. there is one separate source file for each CTA, when there probably should just be one bundle.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

sebasjm

2022-09-07 11:51

developer   ~0019099

09b085d24b2a8d4e7723afe82dfd46dd9d36a71a remove every file from dist folder that does not belong to the webextension (test and stories)

./pack.sh prod (called from the makefile) create a distribution zip without .map
./pack.sh dev keeps the .map files for development

90% of the js is shared between all js in the dist folder, it can be improve event further. I'm keeping this open but with less priority.

Florian Dold

2022-09-07 13:42

manager   ~0019100

The WebExtension is now back to 1.2MB zipped, without sourcemaps. I think this is good enough!

Issue History

Date ModifiedUsernameFieldChange
2022-09-06 21:33Florian DoldNew Issue
2022-09-06 21:33Florian DoldStatusnew => assigned
2022-09-06 21:33Florian DoldAssigned To => sebasjm
2022-09-07 11:51sebasjmNote Added: 0019099
2022-09-07 11:52sebasjmPriorityurgent => low
2022-09-07 11:52sebasjmSeveritymajor => minor
2022-09-07 11:52sebasjmReproducibilityhave not tried => always
2022-09-07 13:42Florian DoldNote Added: 0019100
2022-09-07 13:42Florian DoldStatusassigned => informing
2022-09-07 13:42Florian DoldResolutionopen => fixed
2022-10-20 08:47Christian GrothoffFixed in Version => 0.9
2022-10-20 08:48Christian GrothoffTarget Version => 0.9
2022-11-04 19:52Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)