View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007299 | Taler | wallet-core | public | 2022-08-11 22:14 | 2022-11-04 19:52 |
| Reporter | Christian Grothoff | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Target Version | 0.9 | Fixed in Version | 0.9 | ||
| Summary | 0007299: taler-wallet core attempts to pay even if wire method mismatches | ||||
| Description | The contract terms contain the wire method. Some tests set it to 'x-taler-bank', even though the exchange (as seen in /wire) only supported 'sepa'. The wallet nevertheless attempts to pay. The result is not pretty. It seems the merchant backend doesn't even forward the payment attempt (after getting /wire), but then doesn't give a good message to the wallet *or* the wallet handles it badly. Not sure which yet... ;-) | ||||
| Tags | No tags attached. | ||||
| Seems this is reproduced by the current test_merchant_product_creation.sh: 2022-08-12T00:15:13.492544+0200 taler-merchant-httpd-227898(JNQGD1MM2HR02JCPZHTD7X9WAG) INFO Exchange supports `iban' as a wire method (but we do not use that one) 2022-08-12T00:15:13.492577+0200 taler-merchant-httpd-227898(JNQGD1MM2HR02JCPZHTD7X9WAG) WARNING Exchange does not support our wire method. Retrying in 1 m 2022-08-12T00:15:28.498586+0200 taler-merchant-httpd-227898(JNQGD1MM2HR02JCPZHTD7X9WAG) INFO Request for `/instances/test/orders/2022.224-030B375NVSCCW/pay' completed with HTTP status 504 (0) | |
| Is this really something that the wallet must check? This seems like the merchant configuration is wrong here and/or the contract terms are invalid. I guess the wallet *could* output a "merchant is misconfigured" message The wallet currently only uses the wire method to compute wire fees (to potentially cover wire fees when the merchant doesn't cover them). If the merchant specifies a wire method that the exchange doesn't specify, it assumes that these fees are zero. | |
| Fixed and tested in 43b893b8c. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-08-11 22:14 | Christian Grothoff | New Issue | |
| 2022-08-11 22:14 | Christian Grothoff | Status | new => assigned |
| 2022-08-11 22:14 | Christian Grothoff | Assigned To | => Florian Dold |
| 2022-08-11 22:16 | Christian Grothoff | Note Added: 0019004 | |
| 2022-08-12 08:45 | Florian Dold | Note Added: 0019005 | |
| 2022-09-05 13:39 | Florian Dold | Status | assigned => informing |
| 2022-09-05 13:39 | Florian Dold | Resolution | open => fixed |
| 2022-09-05 13:39 | Florian Dold | Note Added: 0019090 | |
| 2022-10-20 08:47 | Christian Grothoff | Fixed in Version | => 0.9 |
| 2022-10-20 08:48 | Christian Grothoff | Target Version | => 0.9 |
| 2022-11-04 19:52 | Christian Grothoff | Status | informing => closed |
| 2023-04-13 18:36 | Florian Dold | Category | wallet (TS core) => wallet-core |