View Issue Details

IDProjectCategoryView StatusLast Update
0007240Talerexchangepublic2022-11-04 19:52
ReporterttnAssigned TottnResolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityblockReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.9Fixed in Version0.9 
Summary0007240: duplicate Number in src/include/taler_signatures.h
DescriptionHere is an excerpt from that file:

/**
 * Signature affirming a partner configuration for wads.
 */
#define TALER_SIGNATURE_MASTER_PARTNER_DETAILS 1032

/*********************************************/
/* Exchange online signatures (with signing key) */
/*********************************************/

/**
 * Purpose for the state of a reserve, signed by the exchange's signing
 * key.
 */
#define TALER_SIGNATURE_EXCHANGE_RESERVE_STATUS 1032


Note that both #define values are 1032.
This might be fine for GNU Taler as is, but causes downstream errors
when imported into the GANA recfile, which enforces uniqueness on
the Number field.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2022-05-12 05:56

manager   ~0018902

Good, so this found a bug. Please change the PARNTER_DETAILS one to a different available value - it's not yet in use, so this is a good one to change.

ttn

2022-05-12 11:48

reporter   ~0018903

See https://git.taler.net/exchange.git/commit/?id=33312e5abfb194c3a4aa9939a270c7d665b86a32
I chose 1048 after scanning the GANA database (also).

Issue History

Date ModifiedUsernameFieldChange
2022-05-11 23:28ttnNew Issue
2022-05-11 23:28ttnStatusnew => assigned
2022-05-11 23:28ttnAssigned To => Christian Grothoff
2022-05-12 05:56Christian GrothoffNote Added: 0018902
2022-05-12 05:57Christian GrothoffAssigned ToChristian Grothoff => ttn
2022-05-12 11:48ttnStatusassigned => informing
2022-05-12 11:48ttnResolutionopen => fixed
2022-05-12 11:48ttnNote Added: 0018903
2022-10-20 08:47Christian GrothoffFixed in Version => 0.9
2022-10-20 08:48Christian GrothoffTarget Version => 0.9
2022-11-04 19:52Christian GrothoffStatusinforming => closed