View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007164 | Taler | wallet (WebExtension) | public | 2022-01-27 18:49 | 2022-11-04 19:52 |
| Reporter | Florian Dold | Assigned To | sebasjm | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 0.9 | ||||
| Summary | 0007164: in-wallet pages break back button when payment is requested | ||||
| Description | When the wallet handles a "taler://pay" header, the back button doesn't work anymore. Instead of going back to the QR code and/or going back to the article index on shop.demo.taler.net, the back button just stays in the wallet page. | ||||
| Tags | No tags attached. | ||||
| fixed in c47311b4..47bd790b | |
| The back button now seems to work for withdrawal. However, on Firefox I'm still "trapped" in the payment dialog. Reproducible on the blog demo shop. | |
| with balance in the wallet activate "Automatically open wallet" go to the demo shop click the first article should see the payment confirmation page chrome behaviour (correct): * hitting back button go to the shop web page firefox behavior (incorrect): * hitting back button does some work but stays * hitting again goes to the shop page | |
| the is breaking especially after e84cb95887 since reading the headers for a 402 request is non-blocking we are waiting and then redirecting to the wallet. using loadReplace parameter on chrome.tabs.update seems to be the right choice and works as expected it is documented on Mozilla [1] but not for chrome [2] an alternative could be using browser.tabs.executeScript [1] https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/update loadReplaceOptional boolean. Whether the new URL should replace the old URL in the tab's navigation history, as accessed via the "Back" button. For example, suppose the user creates a new tab using Ctrl+T. By default, in Firefox, this would load "about:newtab". If your extension then updates this page using tabs.update, without loadReplace, the "Back" button will be enabled and will take the user back to "about:newtab". If the extension sets loadReplace, then the "Back" button will be disabled and it will be just as if the URL supplied by the extension was the first page visited in that tab. Note though that the original URL will still appear in the browser's global history. [2] https://developer.chrome.com/docs/extensions/reference/tabs/#method-update | |
| fix at 88bb9436 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2022-01-27 18:49 | Florian Dold | New Issue | |
| 2022-01-27 18:49 | Florian Dold | Status | new => assigned |
| 2022-01-27 18:49 | Florian Dold | Assigned To | => Florian Dold |
| 2022-01-27 19:21 | Florian Dold | Assigned To | Florian Dold => sebasjm |
| 2022-01-31 17:56 | sebasjm | Note Added: 0018674 | |
| 2022-01-31 17:56 | sebasjm | Status | assigned => informing |
| 2022-01-31 17:56 | sebasjm | Resolution | open => fixed |
| 2022-02-01 10:35 | Florian Dold | Status | informing => assigned |
| 2022-02-01 10:35 | Florian Dold | Note Added: 0018675 | |
| 2022-03-15 15:06 | sebasjm | Status | assigned => acknowledged |
| 2022-03-15 15:06 | sebasjm | Note Added: 0018794 | |
| 2022-03-21 12:39 | sebasjm | Note Added: 0018822 | |
| 2022-03-21 12:41 | sebasjm | Status | acknowledged => informing |
| 2022-03-21 12:41 | sebasjm | Note Added: 0018823 | |
| 2022-10-20 08:48 | Christian Grothoff | Target Version | => 0.9 |
| 2022-11-04 19:52 | Christian Grothoff | Status | informing => closed |
| 2023-04-13 18:37 | Florian Dold | Category | wallet (WebExtensions) => wallet (WebExtension) |