View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0007060 | Taler | exchange | public | 2021-11-01 14:51 | 2021-11-21 14:26 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | no change required | ||
| Product Version | git (master) | ||||
| Target Version | 0.9 | Fixed in Version | 0.9 | ||
| Summary | 0007060: exchange DB connection does not re-run prepared statements on re-connect | ||||
| Description | The function prepare_statements in plugin_exchangedb_postgres.c is only called from internal_setup, and only if pg->init is set to false. However, we never set pg->init to true if we lose the DB connection. Worse, GNUNET_PQ_reconnect_if_down doesn't let is know if we reconnected or not. Ideally, libgnunetpq would track whether prepared statements have been run or not. The problem with that approach is that currently libgnunetpq eagerly executes prepared statements, even though tables might not be created yet, which causes these statements to fail. But I don't understand why this matters, since we only need to do this for DB connection that normally access the DB, and not for the special administrative DB transactions. | ||||
| Tags | No tags attached. | ||||
| Bug was based on a misunderstanding by Florian on the GNUNET_PQ_prepare_statements() logic which does already ensure reinitialization of all prepared statements on reconnect. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-11-01 14:51 | Florian Dold | New Issue | |
| 2021-11-01 14:51 | Florian Dold | Status | new => assigned |
| 2021-11-01 14:51 | Florian Dold | Assigned To | => Christian Grothoff |
| 2021-11-21 14:26 | Christian Grothoff | Status | assigned => informing |
| 2021-11-21 14:26 | Christian Grothoff | Resolution | open => no change required |
| 2021-11-21 14:26 | Christian Grothoff | Fixed in Version | => 0.9 |
| 2021-11-21 14:26 | Christian Grothoff | Note Added: 0018516 | |
| 2021-11-21 14:26 | Christian Grothoff | Target Version | 0.9.1 => 0.9 |
| 2021-11-21 14:26 | Christian Grothoff | Status | informing => closed |