View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0007056AnastasisGeneralpublic2021-10-28 18:502022-09-26 18:50
Reportersebasjm Assigned ToFlorian Dold Due Date
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.3.0Fixed in Version0.3.0 
Summary0007056: anastasis reducer: make actions consistent
DescriptionThe reducer has a "principal-state" defined by the property "recovery_state" or "backup_state" and sub-states depending on the "principal-state"

My proposal:
1.- principal-state should only change with actions "back" and "next". "next" should validate that the sub-state is correct before moving and "back" should always clean up the sub-state.
2.- other actions should not change the "recovery_state" or "backup_state" property.

Current implementation:
It almost follow this rule.
Some case like action "select_country" in state "CountrySelecting" doesn't.

TagsNo tags attached.

Activities

Christian Grothoff

2022-04-12 20:16

manager   ~0018859

Not quite. 'next' should take no arguments, but sometimes we do need arguments! With the latest change to next=>select_version, this is now consistent (and Florian & Christian are OK with it).

Issue History

Date ModifiedUsernameFieldChange
2021-10-28 18:50sebasjmNew Issue
2021-10-28 18:50sebasjmStatusnew => assigned
2021-10-28 18:50sebasjmAssigned To => Florian Dold
2021-11-06 16:32Christian GrothoffProjectTaler => Anastasis
2021-11-06 16:32Christian GrothoffCategorywallet (TS core) => General
2022-04-12 20:16Christian GrothoffNote Added: 0018859
2022-04-12 20:16Christian GrothoffStatusassigned => resolved
2022-04-12 20:16Christian GrothoffResolutionopen => fixed
2022-04-12 20:16Christian GrothoffFixed in Version => 0.3.0
2022-04-12 20:16Christian GrothoffProduct Versiongit (master) => Git master
2022-04-12 20:16Christian GrothoffTarget Versiongit (master) => 0.3.0
2022-09-26 18:50Christian GrothoffStatusresolved => closed