0007039: merchant contract terms hashing violates RFC 8785

ID	Project	Category	View Status	Date Submitted	Last Update
0007039	Taler	merchant backend	public	2021-10-15 09:44	2022-11-04 19:53

Reporter	Florian Dold	Assigned To	Florian Dold	Resolution deadline
Implementer		Reviewer
Release signed by		Deployed by
Verifier		Communicator
Data protection authority notification required	No
CSIRT notification required	No
Estimated effort (hours)		Actual effort (hours)	0
Fast-track	No
Work package	none
Priority	high	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	git (master)
Target Version	0.9	Fixed in Version	0.9

Summary	0007039: merchant contract terms hashing violates RFC 8785
Description	The merchant currently doesn't replace Unicode characters by escape characters like RFC 8785 Section 3.2.2.2 [1] demands. The wallet does follow RFC 8785, and thus the merchant and wallet disagree on the contract terms hash. [1] https://datatracker.ietf.org/doc/html/rfc8785#section-3.2.2.2
Tags	No tags attached.

Christian Grothoff 2021-11-20 23:53 manager ~0018505	a5a3b2ea..ae2ce4aa might just implement this insanity correctly. Florian: Please check.

sebasjm 2021-11-25 15:59 developer ~0018541	IIRC this was opened because of a contract signature mismatch when trying to pay for an article in the essay shop. I was able to reproduce it again trying to buy: * Did You Say “Intellectual Property”? It's a Seductive Mirage Others articles work ok. Selection_999(132).png (20,040 bytes) Selection_999(132).png (20,040 bytes)

sebasjm 2021-11-25 16:00 developer ~0018542	re opened

Christian Grothoff 2022-01-25 18:21 manager ~0018668	https://www.unicode.org/reports/tr15/ might also hurt us here. This came up with respect to UTF-8 canonicalization of GNS labels!

Florian Dold 2022-01-27 21:31 manager ~0018673 Last edited: 2022-01-27 21:31	This is fixed now. AFAICT RFC 8785 does not actually require normalization of Unicode, i.e. code points are untouched.

Date Modified	Username	Field	Change
2021-10-15 09:44	Florian Dold	New Issue
2021-10-15 09:44	Florian Dold	Status	new => assigned
2021-10-15 09:44	Florian Dold	Assigned To	=> Christian Grothoff
2021-10-15 09:48	Florian Dold	Priority	normal => high
2021-10-15 09:48	Florian Dold	Severity	minor => major
2021-10-15 09:48	Florian Dold	Reproducibility	have not tried => always
2021-10-15 09:48	Florian Dold	Product Version	=> git (master)
2021-10-15 09:48	Florian Dold	Target Version	=> 0.9.1
2021-11-20 23:53	Christian Grothoff	Assigned To	Christian Grothoff => Florian Dold
2021-11-20 23:53	Christian Grothoff	Status	assigned => feedback
2021-11-20 23:53	Christian Grothoff	Note Added: 0018505
2021-11-20 23:53	Christian Grothoff	Target Version	0.9.1 => 0.9
2021-11-25 15:59	sebasjm	Note Added: 0018541
2021-11-25 15:59	sebasjm	File Added: Selection_999(132).png
2021-11-25 16:00	sebasjm	Status	feedback => assigned
2021-11-25 16:00	sebasjm	Note Added: 0018542
2022-01-25 18:21	Christian Grothoff	Note Added: 0018668
2022-01-27 21:31	Florian Dold	Status	assigned => informing
2022-01-27 21:31	Florian Dold	Resolution	open => fixed
2022-01-27 21:31	Florian Dold	Note Added: 0018673
2022-01-27 21:31	Florian Dold	Note Edited: 0018673
2022-04-12 16:31	Christian Grothoff	Fixed in Version	=> 0.9
2022-11-04 19:53	Christian Grothoff	Status	informing => closed
2025-03-22 13:09	Christian Grothoff	Category	mechant backend => merchant backend