View Issue Details

IDProjectCategoryView StatusLast Update
0006995Talermerchant backendpublic2022-11-04 19:53
ReporterFlorian Dold Assigned Tosebasjm Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.8 
Target Version0.9Fixed in Version0.9 
Summary0006995: fix style, text and structural issues with merchant backend HTML pages
DescriptionWhile the usage of the old Taler logo has been removed, the new logo is still not used in the merchant backend HTML pages.

It's currently very difficult to make changes to these pages, as there is no way to define shared material between pages. We should put the common JS and CSS (and maybe some HTML like the footer) into separate files that are included from every top-level page.

Furthermore, we need to review the text that appears on the pages for user-friendliness.

Examples:
* Is a payment "requested" or "required"
* There is no explanation about re-purchase detection. For an order with a fulfillment URL, it might be good to mention that you can scan the QR code and then *don't* have to pay again if it's already paid
* The language is not simple and friendly, but academic. "Alternatively", "Finally", sounds like we're about to write a paper.
* On the page for the order status after payment, we don't provide a link to the fulfillment URL. (Kinda related to 0006459)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2021-08-20 19:30

manager   ~0018117

Belen, could you please have a look at the various files in merchant.git/contrib/*.mcpp and see if you can improve the language?

belen

2021-08-23 13:25

reporter   ~0018120

I can certainly try. It would be good to see the text in context, though. Is there an (easy-ish) way to view the html pages?

Christian Grothoff

2021-08-23 14:22

manager   ~0018121

Well, largely demo.taler.net feeds from them. To see the one with the refund, you'll need to scroll to the bottom of the article (after purchase) and click on refund.

Also, they may not show if you have a WebExtension wallet installed with the 'nice' permissions, as then the wallet takes over immediately. So using the Android app + a browser without WebExtension would work best.

belen

2021-08-24 15:44

reporter   ~0018125

What about something like the attached?

The "Or open your Taler wallet" button replaces "Click this link to open your system's Taler wallet if it exists."

The "Don't have a Taler wallet yet? Install it!" link goes to https://taler.net/en/wallet.html

The copy in depleted_tip.en.mcpp would need to change to:

"Tip already collected"
"You have already collected this tip"

I cannot access the order details page at the moment: the Android wallet gives an error when I try to withdraw or pay. So I am not sure if this page also needs some changes.
offer_refund.png (50,233 bytes)   
offer_refund.png (50,233 bytes)   
offer_tip.png (49,535 bytes)   
offer_tip.png (49,535 bytes)   
request_payment.png (49,658 bytes)   
request_payment.png (49,658 bytes)   

Christian Grothoff

2021-08-24 16:27

manager   ~0018126

ecf18ea..8bbe228 adjusts the templates based on Belen's suggestions above.

Christian Grothoff

2021-08-24 16:29

manager   ~0018127

Last edited: 2021-08-24 16:29

Still TODO:
- introduce new Taler logo => Sebastian?
- order detail page => blocked on Demo working for Belen
- not sure the CSS/Design is good yet => Sebastian?
- There is no explanation about re-purchase detection. For an order with a fulfillment URL, it might be good to mention that you can scan the QR code and then *don't* have to pay again if it's already paid.

belen

2021-08-25 11:00

reporter   ~0018128

I can suggest a way to display the new logo, but I would need to know what is the version of the logo I should use. Is it the one in https://taler.net/?

Also, how can I see the screens involved in the re-purchase detection?

Thanks!

Christian Grothoff

2021-08-25 11:04

manager   ~0018129

Yes, the taler.net logo (three blue rings with or without 'taler' text).

Re-purchase detection doesn't involve any additional screens. It is what happens if you
1) buy article with one wallet (say mobile phone in a firefox browser)
2) select same digital product again in another browser
3) *attempt* to pay with the same wallet that already purchased the article, and
4) Taler allows you to get the digital product from the different browser without paying *again*.

sebasjm

2021-08-25 12:31

developer   ~0018131

I will move this 5 pages into merchant-backend and then imported like we do with spa.html

This files

./contrib/depleted_tip.en.mcpp
./contrib/show_order_details.en.mcpp
./contrib/request_payment.en.mcpp
./contrib/offer_refund.en.mcpp
./contrib/offer_tip.en.mcpp

will be renamed the from .en.mcpp to .html

i18n could be handled with javascript like we do in backoffice. Let me know if a file for each lang is preferred in this situation.

Christian Grothoff

2021-12-26 13:00

manager   ~0018592

We should not rely on JavaScript if we can avoid it, especially as Taler payments do generally work even if JavaScript is disabled. So that precludes client-side i18n logic. Also, once we have _many_ languages, sending the strings for all language always over the network seems like a bad idea. So let's generate one page per language and keep it static.

Issue History

Date ModifiedUsernameFieldChange
2021-08-18 14:11Florian DoldNew Issue
2021-08-18 14:11Florian DoldStatusnew => assigned
2021-08-18 14:11Florian DoldAssigned To => Christian Grothoff
2021-08-18 14:13Florian DoldDescription Updated
2021-08-20 19:30Christian GrothoffNote Added: 0018117
2021-08-20 19:31Christian GrothoffAssigned ToChristian Grothoff => belen
2021-08-23 13:25belenNote Added: 0018120
2021-08-23 14:22Christian GrothoffNote Added: 0018121
2021-08-24 15:44belenNote Added: 0018125
2021-08-24 15:44belenFile Added: offer_refund.png
2021-08-24 15:44belenFile Added: offer_tip.png
2021-08-24 15:44belenFile Added: request_payment.png
2021-08-24 16:27Christian GrothoffNote Added: 0018126
2021-08-24 16:29Christian GrothoffNote Added: 0018127
2021-08-24 16:29Christian GrothoffNote Edited: 0018127
2021-08-24 16:29Christian GrothoffProduct Version => 0.8
2021-08-24 16:29Christian GrothoffTarget Version0.9.1 => 0.8.5
2021-08-25 11:00belenNote Added: 0018128
2021-08-25 11:04Christian GrothoffNote Added: 0018129
2021-08-25 12:31sebasjmNote Added: 0018131
2021-12-26 13:00Christian GrothoffNote Added: 0018592
2021-12-26 13:00Christian GrothoffAssigned Tobelen => sebasjm
2021-12-26 13:00Christian GrothoffPrioritynormal => high
2022-01-19 03:49sebasjmStatusassigned => informing
2022-01-19 03:49sebasjmResolutionopen => fixed
2022-04-12 16:30Christian GrothoffFixed in Version => 0.9
2022-04-12 16:30Christian GrothoffTarget Version0.8.5 => 0.9
2022-11-04 19:53Christian GrothoffStatusinforming => closed
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend