View Issue Details

IDProjectCategoryView StatusLast Update
0006967Talerexchangepublic2021-09-02 16:14
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006967: bad error reporting in taler-exchange-offline
Descriptiontaler-exchange-offline@buster:/home/vagrant/repos$ taler-exchange-offline download
Jul 29 03:51:50-834402 taler-exchange-offline-15436 WARNING External protocol violation detected at json.c:781.
Jul 29 03:51:50-834522 taler-exchange-offline-15436 WARNING External protocol violation detected at json.c:807.
Jul 29 03:51:50-834552 taler-exchange-offline-15436 ERROR Unexpected response code 0/10 for exchange management get keys
Jul 29 03:51:50-834574 taler-exchange-offline-15436 ERROR Failed to download keys: (null) (HTTP status: 0/10)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2021-07-29 17:28

manager   ~0018025

Actually, the taler-exchange-offline tool tries to connect to [exchange]/base_url.

The default for this is a port on localhost that is unbound in my environment, but the error message doesn't make *anything* clear.

taler-exchange-offline@buster:/home/vagrant/repos$ taler-config -s exchange -o base_url
http://localhost:8081/

Christian Grothoff

2021-07-29 21:04

manager   ~0018026

Well, technically an HTTP status of '0' always means that we could not talk to the HTTP server.

Florian Dold

2021-07-30 09:37

manager   ~0018030

Sure, but how is a sysadmin supposed to find out easily which server the program is trying to talk to, if we don't print any of this information?

Also, I'm not sure why we're doing JSON parsing here.

Christian Grothoff

2021-07-30 12:24

manager   ~0018031

d821db36..c0d4a35a fixes this, avoiding both the JSON parse logging and also now reporting the bogus URL in the log.

Christian Grothoff

2021-09-02 16:14

manager   ~0018223

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2021-07-29 17:24Florian DoldNew Issue
2021-07-29 17:24Florian DoldStatusnew => assigned
2021-07-29 17:24Florian DoldAssigned To => Christian Grothoff
2021-07-29 17:28Florian DoldNote Added: 0018025
2021-07-29 21:04Christian GrothoffNote Added: 0018026
2021-07-30 09:37Florian DoldNote Added: 0018030
2021-07-30 12:24Christian GrothoffStatusassigned => informing
2021-07-30 12:24Christian GrothoffResolutionopen => fixed
2021-07-30 12:24Christian GrothoffFixed in Version => 0.8
2021-07-30 12:24Christian GrothoffNote Added: 0018031
2021-07-30 12:24Christian GrothoffProduct Version => git (master)
2021-07-30 12:24Christian GrothoffTarget Version => 0.8
2021-08-24 14:22Christian GrothoffStatusinforming => closed
2021-09-02 16:13Christian Grothoff
2021-09-02 16:14Christian GrothoffNote Added: 0018223