View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006952 | Taler | documentation | public | 2021-07-23 11:42 | 2023-09-23 13:09 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | text | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 0.9.3 | Fixed in Version | 0.9.3 | ||
| Summary | 0006952: document how public /pay handles refunded coins | ||||
| Description | The current implementation allows them, but excludes the refunded amount from the total payment amount. | ||||
| Tags | No tags attached. | ||||
| From our workshop discussion: The merchant should actually just *reject* /pay requests with refunded coins, as due to the exchange API, such payments can never work in the first place. Once a coin is refunded, it can't be spent on the same h_contract_terms again. The merchant code should not accommodate with extra, complex logic for an input that will lead to an error at the exchange anyway. | |
| Actually it turns out that the exchange doesn't properly document how /deposit handles refunded coins for the same h_contract_terms. While trying to experiment with the exchange's behavior, I stumbled on 0007792. | |
| Assigning to Christian to review the exchange docs for coin deposit/refund, which in turn informs the documentation for the merchant's /pay endpoint. | |
| 56e7647..991e5d2 clarifies the /deposit (and /batch-deposit) endpoints with respect to coin re-use. 991e5d2..a7dd26c clairfies the /pay endpoint hopefully making it clearer that you must not use the same coin-pub a second time for a purchase of the same contract after a /refund for the same purchase. | |
| Documentation LGTM now. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-07-23 11:42 | Florian Dold | New Issue | |
| 2021-07-23 11:42 | Florian Dold | Status | new => assigned |
| 2021-07-23 11:42 | Florian Dold | Assigned To | => Christian Grothoff |
| 2021-07-23 12:18 | Florian Dold | Note Added: 0018008 | |
| 2021-07-23 12:22 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2021-07-23 16:37 | Christian Grothoff | Severity | minor => text |
| 2021-08-01 13:07 | Christian Grothoff | Category | mechant backend => documentation |
| 2021-08-01 13:07 | Christian Grothoff | Product Version | => git (master) |
| 2023-04-04 14:08 | Florian Dold | Target Version | => 0.9.3 |
| 2023-04-05 16:21 | Florian Dold | Note Added: 0020028 | |
| 2023-04-05 16:21 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2023-04-05 16:22 | Florian Dold | Note Added: 0020029 | |
| 2023-04-08 07:56 | Christian Grothoff | Relationship added | related to 0007267 |
| 2023-04-08 07:59 | Christian Grothoff | Note Added: 0020040 | |
| 2023-04-08 08:00 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2023-04-08 08:00 | Christian Grothoff | Status | assigned => feedback |
| 2023-06-02 12:40 | Florian Dold | Status | feedback => informing |
| 2023-06-02 12:40 | Florian Dold | Resolution | open => fixed |
| 2023-06-02 12:40 | Florian Dold | Note Added: 0020250 | |
| 2023-09-23 13:07 | Christian Grothoff | Fixed in Version | => 0.9.3 |
| 2023-09-23 13:09 | Christian Grothoff | Status | informing => closed |